Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accounts package ts migration and refactor - sprint 8 #9791

Conversation

likhith-deriv
Copy link
Contributor

@likhith-deriv likhith-deriv commented Aug 22, 2023

Changes:

  • TS Migration: Configs files in Accounts package
  • TS Migration: Sections/Security/Passwords files in Accounts package
  • Refactor: Custom DateOfBirth field and FormInput field component
  • Refactor: Create Real account flow

likhith-deriv and others added 30 commits July 18, 2023 11:36
* refactor: ♻️ refactor component to remove unwanted code

* feat: removed commented code

* test: ✅ added testcase

* test: 🧪 added tests

* refactor: ♻️ incorporated review comments

* refactor: ♻️ incorporated review comments

* refactor: ♻️ incorporated review comments
* refactor: ♻️ migrated code to TS

* refactor: ♻️ incorporated review comments

* refactor: ♻️ incorporated review comments

* Update packages/account/src/Types/common-prop.type.ts

Co-authored-by: yauheni-deriv <103182683+yauheni-deriv@users.noreply.github.com>

---------

Co-authored-by: yauheni-deriv <103182683+yauheni-deriv@users.noreply.github.com>
* refactor: ⚡ refactored currency selector component

* fix: 🚨 lint errors

* feat: incorporated store values

* fix: 🎨 split code into small components

* fix: 🎨 removed un-necessary array

* refactor: ♻️ incorporated review comments

* refactor: ♻️ incorporated review comments

* resolved failing test cases

* chore: incorporated review comment

* fix: build issue

* fix: build issue
* chore: migrated deriv-email and unlink component

* chore: migrate password-platform to tsx

* chore: migrate password-platform to tsx

* chore: added missing test cases

* ref: incorporated review comments

* refactor: incorporated review comments

* refactor: incorporated review comments

* refactor: incorporated review comments

* ref: Incorporated review somments
* chore: config files ts migartion and refactor

* refactor: test case for config func

* fix: config typing

* refactor: remove custom accounts residence type

* refactor: review comment

* chore: added test cases

* fix: revert boolean in types

* refactor: default value fields

* refactor: files types, import react types

* refactor: react types

* fix: condition rule

* fix: failing testcase

---------

Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”>
…-8' into likhith/WEBREL-795/Refactor-real-account-signup-flow
* refactor: migrate form-fields file

* refactor: migrate form-fields file

* ref: incorporated review comments
@gitguardian
Copy link

gitguardian bot commented Oct 2, 2023

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id Secret Commit Filename
- Generic High Entropy Secret 9ca927b nx.json View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

matin-deriv
matin-deriv previously approved these changes Oct 2, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 7 Code Smells

No Coverage information No Coverage information
0.5% 0.5% Duplication

@vinu-deriv vinu-deriv merged commit c2e6360 into deriv-com:master Oct 4, 2023
vinu-deriv pushed a commit that referenced this pull request Oct 10, 2023
* fix: ⚡ refactored Address-details component

* fix: 🎨 failing testcases

* refactor: ♻️ incorporated review comments

* feat: 🔥 removed PlatformContext

* fix: testcase failure

* refactor: ♻️ incorporated review comments

* refactor: ♻️ refactor component to remove unwanted code (#44)

* refactor: ♻️ refactor component to remove unwanted code

* feat: removed commented code

* test: ✅ added testcase

* test: 🧪 added tests

* refactor: ♻️ incorporated review comments

* refactor: ♻️ incorporated review comments

* refactor: ♻️ incorporated review comments

* refactor: ♻️ migrated code to TS (#45)

* refactor: ♻️ migrated code to TS

* refactor: ♻️ incorporated review comments

* refactor: ♻️ incorporated review comments

* Update packages/account/src/Types/common-prop.type.ts

Co-authored-by: yauheni-deriv <103182683+yauheni-deriv@users.noreply.github.com>

---------

Co-authored-by: yauheni-deriv <103182683+yauheni-deriv@users.noreply.github.com>

* refactor: ⚡ refactored currency selector component (#43)

* refactor: ⚡ refactored currency selector component

* fix: 🚨 lint errors

* feat: incorporated store values

* fix: 🎨 split code into small components

* fix: 🎨 removed un-necessary array

* refactor: ♻️ incorporated review comments

* refactor: ♻️ incorporated review comments

* resolved failing test cases

* chore: incorporated review comment

* fix: build issue

* fix: build issue

* ref: incorporated review comments

* refactor: Modified code to contain hooks

* refactor: Modified code to contain hooks

* replaced test component

* fix: eslint issues

* fix: failing testcases

* ref: Incorporated review somments

* Likhith/webrel 780/migrate Email and password section (#7)

* chore: migrated deriv-email and unlink component

* chore: migrate password-platform to tsx

* chore: migrate password-platform to tsx

* chore: added missing test cases

* ref: incorporated review comments

* refactor: incorporated review comments

* refactor: incorporated review comments

* refactor: incorporated review comments

* ref: Incorporated review somments

* chore: config files ts migration and refactor (#8)

* chore: config files ts migartion and refactor

* refactor: test case for config func

* fix: config typing

* refactor: remove custom accounts residence type

* refactor: review comment

* chore: added test cases

* fix: revert boolean in types

* refactor: default value fields

* refactor: files types, import react types

* refactor: react types

* fix: condition rule

* fix: failing testcase

---------

Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”>

* fix: incorporated review comments

* fix: failing testcase

* refactor: migrate form-fields file (#10)

* refactor: migrate form-fields file

* refactor: migrate form-fields file

* ref: incorporated review comments

* fix: failing testcase

* fix: incorporated review comments

* fix: incorporated review comments

* fix: incorporated review comments

* fix: resolved Sonar lint errors

* fix: tslint issues

* fix: review comments

* fix: review comments

* refactor: 🎨 incorporated types for test cases

* fix: 🦺 incorporated review comments

* fix: 🎨 incorporated ui-store-fix

* fix: ⚰️ replaced deprecated hooks

* fix: 🔥 unused dependency

* Merge branch 'master' into KYC-accounts-package-TS-migration--test-coverage/sprint-8

* chore: added package-lock

* fix: added value for mock-store

---------

Co-authored-by: yauheni-deriv <103182683+yauheni-deriv@users.noreply.github.com>
Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”>
Co-authored-by: Shahzaib <shahzaib@deriv.com>
vinu-deriv pushed a commit that referenced this pull request Oct 10, 2023
* fix: ⚡ refactored Address-details component

* fix: 🎨 failing testcases

* refactor: ♻️ incorporated review comments

* feat: 🔥 removed PlatformContext

* fix: testcase failure

* refactor: ♻️ incorporated review comments

* refactor: ♻️ refactor component to remove unwanted code (#44)

* refactor: ♻️ refactor component to remove unwanted code

* feat: removed commented code

* test: ✅ added testcase

* test: 🧪 added tests

* refactor: ♻️ incorporated review comments

* refactor: ♻️ incorporated review comments

* refactor: ♻️ incorporated review comments

* refactor: ♻️ migrated code to TS (#45)

* refactor: ♻️ migrated code to TS

* refactor: ♻️ incorporated review comments

* refactor: ♻️ incorporated review comments

* Update packages/account/src/Types/common-prop.type.ts

Co-authored-by: yauheni-deriv <103182683+yauheni-deriv@users.noreply.github.com>

---------

Co-authored-by: yauheni-deriv <103182683+yauheni-deriv@users.noreply.github.com>

* refactor: ⚡ refactored currency selector component (#43)

* refactor: ⚡ refactored currency selector component

* fix: 🚨 lint errors

* feat: incorporated store values

* fix: 🎨 split code into small components

* fix: 🎨 removed un-necessary array

* refactor: ♻️ incorporated review comments

* refactor: ♻️ incorporated review comments

* resolved failing test cases

* chore: incorporated review comment

* fix: build issue

* fix: build issue

* ref: incorporated review comments

* refactor: Modified code to contain hooks

* refactor: Modified code to contain hooks

* replaced test component

* fix: eslint issues

* fix: failing testcases

* ref: Incorporated review somments

* Likhith/webrel 780/migrate Email and password section (#7)

* chore: migrated deriv-email and unlink component

* chore: migrate password-platform to tsx

* chore: migrate password-platform to tsx

* chore: added missing test cases

* ref: incorporated review comments

* refactor: incorporated review comments

* refactor: incorporated review comments

* refactor: incorporated review comments

* ref: Incorporated review somments

* chore: config files ts migration and refactor (#8)

* chore: config files ts migartion and refactor

* refactor: test case for config func

* fix: config typing

* refactor: remove custom accounts residence type

* refactor: review comment

* chore: added test cases

* fix: revert boolean in types

* refactor: default value fields

* refactor: files types, import react types

* refactor: react types

* fix: condition rule

* fix: failing testcase

---------

Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”>

* fix: incorporated review comments

* fix: failing testcase

* refactor: migrate form-fields file (#10)

* refactor: migrate form-fields file

* refactor: migrate form-fields file

* ref: incorporated review comments

* fix: failing testcase

* fix: incorporated review comments

* fix: incorporated review comments

* fix: incorporated review comments

* fix: resolved Sonar lint errors

* fix: tslint issues

* fix: review comments

* fix: review comments

* refactor: 🎨 incorporated types for test cases

* fix: 🦺 incorporated review comments

* fix: 🎨 incorporated ui-store-fix

* fix: ⚰️ replaced deprecated hooks

* fix: 🔥 unused dependency

* Merge branch 'master' into KYC-accounts-package-TS-migration--test-coverage/sprint-8

* chore: added package-lock

* fix: added value for mock-store

---------

Co-authored-by: yauheni-deriv <103182683+yauheni-deriv@users.noreply.github.com>
Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”>
Co-authored-by: Shahzaib <shahzaib@deriv.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants