Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(webapp): fix lint rule vue/multi-word-component-names #691

Merged
merged 4 commits into from
Jun 8, 2023

Conversation

Rotzbua
Copy link
Contributor

@Rotzbua Rotzbua commented Feb 19, 2023

Changes

Fixes all the problems with vue essential lint rule vue/multi-word-component-names.

Advantage

This prevents conflicts with existing and future HTML elements, since all HTML elements are a single word.

Source: https://eslint.vuejs.org/rules/multi-word-component-names.html

Prevents unforeseen side effects.

Reference

Part 2 of merged #677.

Copy link
Contributor

@nils-wisiol nils-wisiol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally for missed components renames. lgtm

@peterthomassen peterthomassen merged commit fa11626 into desec-io:main Jun 8, 2023
@Rotzbua Rotzbua deleted the cs_naming branch June 8, 2023 21:09
Rotzbua added a commit to Rotzbua/desec-stack that referenced this pull request Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants