Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(webapp): use component name instead of string #746

Merged
merged 1 commit into from
Jul 4, 2023

Conversation

Rotzbua
Copy link
Contributor

@Rotzbua Rotzbua commented Jul 1, 2023

Problem

Renaming the components in pr #691 caused runtime issues because constant strings are used.

Solution

Use component name directly.

Copy link
Member

@peterthomassen peterthomassen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@peterthomassen peterthomassen merged commit 6601458 into desec-io:main Jul 4, 2023
@Rotzbua Rotzbua deleted the use_name branch July 4, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants