Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for guid type #122

Closed
wants to merge 5 commits into from

Conversation

mickeyperlstein
Copy link

I noticed that you dont support guid, now you do

@github-actions github-actions bot added the tests Pull request that adds new or changes existing tests label Sep 4, 2024
Copy link

github-actions bot commented Oct 5, 2024

This pull request was marked as stale since it has not been active for a long time

@github-actions github-actions bot added the stale label Oct 5, 2024
@github-actions github-actions bot closed this Dec 4, 2024
@sungam3r sungam3r reopened this Dec 8, 2024
@sungam3r sungam3r removed the stale label Dec 8, 2024
@sungam3r
Copy link
Member

sungam3r commented Dec 8, 2024

Thanks. I doubt about this change. LogMasked was intentionally applied only for string properties to not change any existing types. You changed guid scalar to string scalar. I suggest to made such feature opt-in to not break any existing code.

@sungam3r
Copy link
Member

Thanks, @mickeyperlstein . Was replaced by #126.

@sungam3r sungam3r closed this Dec 15, 2024
@sungam3r sungam3r added the enhancement New feature or request label Dec 15, 2024
Copy link

codecov bot commented Dec 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (c78b7cf) to head (bc94984).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #122   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        11           
  Lines          237       238    +1     
  Branches        35        35           
=========================================
+ Hits           237       238    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request tests Pull request that adds new or changes existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants