-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added support for guid type #122
Conversation
This pull request was marked as stale since it has not been active for a long time |
Thanks. I doubt about this change. LogMasked was intentionally applied only for string properties to not change any existing types. You changed guid scalar to string scalar. I suggest to made such feature opt-in to not break any existing code. |
Thanks, @mickeyperlstein . Was replaced by #126. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #122 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 11 11
Lines 237 238 +1
Branches 35 35
=========================================
+ Hits 237 238 +1 ☔ View full report in Codecov by Sentry. |
I noticed that you dont support guid, now you do