LogMaskedAttribute to handle int,long and guid values

[andreas-moneygate]

No description provided.

[sungam3r]

Please see #122 (comment) . What do you think?

[andreas-moneygate]

Please see #122 (comment) . What do you think?

How about having a property in LogMaskedAttribute allowing other types besides string to be masked?

[sungam3r]

I thought again about it. All non-string properties marked with this attribute ended in default case with ScalarValue.Null. So my reasoning from #122 (comment) is wrong. If now anyone marks int property with that attribute then it effectively becames null.

[sungam3r]

I added LogMaskedAttribute_Nullify_Bool_Property test to verify. Please resolve conflicts and I'll review again.

[sungam3r]

Also you may include changes from #122.

[andreas-moneygate]

@sungam3r
Conflicts resolved

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (88a8732) to head (3f95dbc).
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff            @@
##            master      #126   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        11           
  Lines          239       242    +3     
  Branches        36        36           
=========================================
+ Hits           239       242    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mickeyperlstein]

Although GUID's are not strings, we treat them as such, and do sometimes put in them secure data, not PII but machine II for sure.

[mickeyperlstein]

I also did not appreciate that it took you so long to merge my solution, and that you changed it so it's not my solution is even less appreciative.

It was MY idea, it was MY solution - and yet I get no credit in your product, last time im adding source to your code

[sungam3r]

https://github.com/destructurama/attributed/releases/tag/4.1.0

Thanks one more time, @mickeyperlstein

[sungam3r]

Sorry, it was not intentional, I included you in release notes.

[sungam3r]

With #141 you can mask property of any type, no more need to add custom cases.