Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scenarios.json does not support running with existing features #217

Closed
AlexanderLanin opened this issue Oct 9, 2022 · 1 comment · Fixed by #220
Closed

scenarios.json does not support running with existing features #217

AlexanderLanin opened this issue Oct 9, 2022 · 1 comment · Fixed by #220
Assignees
Labels
feature-request New feature or request

Comments

@AlexanderLanin
Copy link
Contributor

Observation

When ghcr.io/devcontainers/features/python:1 is added as a feature to scenarios.json, it attempts to read local file path: '/workspaces/my-feature/src/ghcr.io/devcontainers/features/python:1'.

Expectation

It will use python feature for testing. Therefore I would see that it behaves correctly regarding installsAfter and my stuff can indeed use python.

Background:

my-feature requires python 3.7, therefore I implemented a version detection in case the available version is too old. However as there is a python feature already, I don't want to add too much complex logic to my script. I have an error message which tells people to use https://github.com/devcontainers/features/tree/main/src/python in addition to my-feature.
However I cannot verify that this would indeed work!

@joshspicer
Copy link
Member

joshspicer commented Oct 10, 2022

Yes, this was also raised in #217 and is good to point out.

The test command currently injects the appropriate relative path for all Features in the scenario, so this is not expected to work (But I agree would be very handy!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants