Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow referencing external Features in devcontainer features test command #220

Merged
merged 3 commits into from
Oct 11, 2022

Conversation

joshspicer
Copy link
Member

closes #217
related: #163
tracking: #139

Does not replace external Features in a Feature's scenarios.json. For example, this lets people test installsAfter with an already published Feature. This PR also adds a test with an external Feature combined with a local Feature.

Also adds two tests for installsAfter - one that must install A -> B and one must install B -> A.

@joshspicer joshspicer requested a review from a team as a code owner October 11, 2022 01:40
@joshspicer joshspicer self-assigned this Oct 11, 2022
@eitsupi
Copy link

eitsupi commented Oct 11, 2022

This is a long-awaited feature in using the feature template!
(For now, it is not possible to run tests in combination with external features like devcontainers/features)

@joshspicer joshspicer merged commit 702e099 into main Oct 11, 2022
@joshspicer joshspicer deleted the joshspicer/external-features-in-test-cmd branch October 11, 2022 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scenarios.json does not support running with existing features
3 participants