-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Surface docker-content-digest
on manifest pulls, manifest annotations per Feature/Template, and info
command clean up
#490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshspicer
changed the title
OCI Registry Implementation additions
Surface Apr 13, 2023
docker-content-digest
oj pull, utilize manifest annotations per Feature/Template, and info
command clean up
joshspicer
changed the title
Surface
Surface Apr 13, 2023
docker-content-digest
oj pull, utilize manifest annotations per Feature/Template, and info
command clean updocker-content-digest
on manifest pulls, manifest annotations per Feature/Template, and info
command clean up
chrmarti
requested changes
Apr 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, a few comments.
…spicer/annotations-and-content-digest
…spicer/annotations-and-content-digest
chrmarti
previously approved these changes
Apr 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
chrmarti
force-pushed
the
joshspicer/annotations-and-content-digest
branch
from
April 19, 2023 09:36
bc0f8c7
to
4d8755d
Compare
chrmarti
previously approved these changes
Apr 19, 2023
samruddhikhandale
approved these changes
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch introduces two small additions to the registry/OCI implementation. Both additions are generally useful to have, and have been extracted from my experimental implementation of 'Feature Dependencies' with a
dependsOn
attribute. This patch, however, does not depend on any dependency-related spec and can be included regardless.Ref: https://github.com/github/codespaces/issues/11243, devcontainers/spec#109
Changes:
When fetching a manifest, also read the
docker-content-digest
header and pass that along to the caller. This will be useful:The open containers image spec includes a map of arbitrary annotations. Supporting the ability to attach annotations to an individual Feature/Template at publish time is a generally useful mechanism to have.
Possible Example (
dev.containers.experimental.dependsOn
) :info
command to consolidate code and allows for a 'verbose' mode that dumps all the info this command can query.