Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

telemetry updates #156

Merged
merged 1 commit into from
Nov 24, 2022
Merged

telemetry updates #156

merged 1 commit into from
Nov 24, 2022

Conversation

kim-tsao
Copy link
Contributor

@kim-tsao kim-tsao commented Nov 24, 2022

Signed-off-by: Kim Tsao ktsao@redhat.com

What does this PR do?:

  • Avoids collecting unintended telemetry where parent URLs and resources are called
  • Updates the client identifier to devfile-library so we can distinguish these events better

Which issue(s) this PR fixes:

devfile/api#981

PR acceptance criteria:

Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.

Will raise this in the community call/slack channel

  • Gosec scans

How to test changes / Special notes to the reviewer:

Corresponding changes were made on the registry-support repo and deployed to a local cluster for testing. Confirmed telemetry is not collected on parent references and intended events have the new client identifier devfile-library

Signed-off-by: Kim Tsao <ktsao@redhat.com>
@codecov
Copy link

codecov bot commented Nov 24, 2022

Codecov Report

Base: 58.95% // Head: 58.68% // Decreases project coverage by -0.27% ⚠️

Coverage data is based on head (c0f2eb0) compared to base (c8f6c26).
Patch coverage: 31.42% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #156      +/-   ##
==========================================
- Coverage   58.95%   58.68%   -0.28%     
==========================================
  Files          36       36              
  Lines        4037     4066      +29     
==========================================
+ Hits         2380     2386       +6     
- Misses       1518     1541      +23     
  Partials      139      139              
Impacted Files Coverage Δ
pkg/util/util.go 38.69% <8.33%> (-0.78%) ⬇️
pkg/devfile/parser/parse.go 53.87% <66.66%> (-0.02%) ⬇️
pkg/devfile/parser/context/content.go 84.78% <100.00%> (+0.69%) ⬆️
pkg/devfile/parser/reader.go 92.50% <100.00%> (+0.09%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kim-tsao kim-tsao requested review from yangcao77 and removed request for elsony and maysunfaisal November 24, 2022 18:06
@openshift-ci
Copy link

openshift-ci bot commented Nov 24, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kim-tsao, yangcao77

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kim-tsao kim-tsao merged commit 8e009f5 into devfile:main Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants