-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
telemetry updates #151
telemetry updates #151
Conversation
Signed-off-by: Kim Tsao <ktsao@redhat.com>
@kim-tsao: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov ReportBase: 43.92% // Head: 43.92% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #151 +/- ##
=======================================
Coverage 43.92% 43.92%
=======================================
Files 6 6
Lines 1020 1020
=======================================
Hits 448 448
Misses 530 530
Partials 42 42
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kim-tsao, michael-valdron The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Kim Tsao ktsao@redhat.com
Please specify the area for this PR
/area registry
What does does this PR do / why we need it:
This change will ignore telemetry coming from indirect calls made by clients
Which issue(s) this PR fixes:
Fixes #?
devfile/api#981
PR acceptance criteria:
Documentation (WIP)
How to test changes / Special notes to the reviewer:
Manually tested by building an image and testing on a local cluster with changes made on the devfile library client devfile/library#156