Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

telemetry updates #151

Merged
merged 1 commit into from
Nov 25, 2022
Merged

telemetry updates #151

merged 1 commit into from
Nov 25, 2022

Conversation

kim-tsao
Copy link
Contributor

Signed-off-by: Kim Tsao ktsao@redhat.com

Please specify the area for this PR
/area registry

What does does this PR do / why we need it:

This change will ignore telemetry coming from indirect calls made by clients

Which issue(s) this PR fixes:

Fixes #?
devfile/api#981

PR acceptance criteria:

  • Test Coverage
    • Are your changes sufficiently tested, and are any applicable test cases added or updated to cover your changes?

Documentation (WIP)

How to test changes / Special notes to the reviewer:

Manually tested by building an image and testing on a local cluster with changes made on the devfile library client devfile/library#156

Signed-off-by: Kim Tsao <ktsao@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Nov 24, 2022

@kim-tsao: The label(s) area/registry cannot be applied, because the repository doesn't have them.

In response to this:

Signed-off-by: Kim Tsao ktsao@redhat.com

Please specify the area for this PR
/area registry

What does does this PR do / why we need it:

This change will ignore telemetry coming from indirect calls made by clients

Which issue(s) this PR fixes:

Fixes #?
devfile/api#981

PR acceptance criteria:

  • Test Coverage
    • Are your changes sufficiently tested, and are any applicable test cases added or updated to cover your changes?

Documentation (WIP)

How to test changes / Special notes to the reviewer:

Manually tested by building an image and testing on a local cluster with changes made on the devfile library client devfile/library#156

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Nov 24, 2022

Codecov Report

Base: 43.92% // Head: 43.92% // No change to project coverage 👍

Coverage data is based on head (1db398b) compared to base (ba1df89).
Patch coverage: 25.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #151   +/-   ##
=======================================
  Coverage   43.92%   43.92%           
=======================================
  Files           6        6           
  Lines        1020     1020           
=======================================
  Hits          448      448           
  Misses        530      530           
  Partials       42       42           
Impacted Files Coverage Δ
index/server/pkg/server/index.go 9.02% <0.00%> (ø)
index/server/pkg/util/telemetry.go 72.60% <0.00%> (ø)
index/server/pkg/server/endpoint.go 36.78% <50.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@michael-valdron michael-valdron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 25, 2022
@openshift-ci
Copy link

openshift-ci bot commented Nov 25, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kim-tsao, michael-valdron
Once this PR has been reviewed and has the lgtm label, please assign johnmcollier for approval by writing /assign @johnmcollier in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kim-tsao kim-tsao merged commit 16e3226 into devfile:main Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
2 participants