Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update controller-gen #33

Merged
merged 4 commits into from
Feb 17, 2023
Merged

Conversation

kim-tsao
Copy link
Contributor

Signed-off-by: Kim Tsao ktsao@redhat.com

Please specify the area for this PR

What does does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #?
devfile/api#1013

In addition to the changes mentioned in this comment, I had to update the controller-manager and kube-rbac-proxy sccs in order to fix the warning on openshift:

Warning: would violate PodSecurity "restricted:v1.24": allowPrivilegeEscalation != false (container "kube-rbac-proxy" must set securityContext.allowPrivilegeEscalation=false), unrestricted capabilities (containers "kube-rbac-proxy", "manager" must set securityContext.capabilities.drop=["ALL"]), seccompProfile (pod or containers "kube-rbac-proxy", "manager" must set securityContext.seccompProfile.type to "RuntimeDefault" or "Localhost")

PR acceptance criteria:

  • Test Coverage
    • Are your changes sufficiently tested, and are any applicable test cases added or updated to cover your changes?
  • Gosec scans

Documentation

How to test changes / Special notes to the reviewer:

Signed-off-by: Kim Tsao <ktsao@redhat.com>
@michael-valdron
Copy link
Member

go mod tidy: go.mod file indicates go 1.18, but maximum supported version is 1.17 our integration tests need updating to support golang 1.18, we could cap it at 1.17 until this support is added.

Copy link
Member

@michael-valdron michael-valdron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from my suggestions there might be other changes needed to stay at golang 1.17.

Dockerfile Show resolved Hide resolved
go.mod Show resolved Hide resolved
Copy link
Member

@michael-valdron michael-valdron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go mod tidy: go.mod file indicates go 1.18, but maximum supported version is 1.17 our integration tests need updating to support golang 1.18, we could cap it at 1.17 until this support is added.

/lgtm

I see your changes for testing support openshift/release#36276 you can disregard my review suggestions.

@openshift-ci openshift-ci bot added the lgtm label Feb 10, 2023
@kim-tsao
Copy link
Contributor Author

/retest

Signed-off-by: Kim Tsao <ktsao@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm label Feb 10, 2023
Copy link
Member

@michael-valdron michael-valdron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Feb 10, 2023
@openshift-ci
Copy link

openshift-ci bot commented Feb 10, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kim-tsao, michael-valdron

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kim-tsao
Copy link
Contributor Author

/retest

Signed-off-by: Kim Tsao <ktsao@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm label Feb 14, 2023
@openshift-ci
Copy link

openshift-ci bot commented Feb 14, 2023

New changes are detected. LGTM label has been removed.

@kim-tsao
Copy link
Contributor Author

/retest

…e to deployment manifest and remove redundant scc

Signed-off-by: Kim Tsao <ktsao@redhat.com>
@kim-tsao
Copy link
Contributor Author

Also updated a couple of dependencies related to upgrading the operator-sdk: https://sdk.operatorframework.io/docs/upgrading-sdk-version/v1.25.0/

@kim-tsao kim-tsao merged commit d6da16a into devfile:main Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants