-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update controller-gen #33
Conversation
Signed-off-by: Kim Tsao <ktsao@redhat.com>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from my suggestions there might be other changes needed to stay at golang 1.17.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
go mod tidy: go.mod file indicates go 1.18, but maximum supported version is 1.17
our integration tests need updating to support golang 1.18, we could cap it at 1.17 until this support is added.
/lgtm
I see your changes for testing support openshift/release#36276 you can disregard my review suggestions.
/retest |
Signed-off-by: Kim Tsao <ktsao@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kim-tsao, michael-valdron The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Signed-off-by: Kim Tsao <ktsao@redhat.com>
New changes are detected. LGTM label has been removed. |
/retest |
…e to deployment manifest and remove redundant scc Signed-off-by: Kim Tsao <ktsao@redhat.com>
Also updated a couple of dependencies related to upgrading the operator-sdk: https://sdk.operatorframework.io/docs/upgrading-sdk-version/v1.25.0/ |
Signed-off-by: Kim Tsao ktsao@redhat.com
Please specify the area for this PR
What does does this PR do / why we need it:
Which issue(s) this PR fixes:
Fixes #?
devfile/api#1013
In addition to the changes mentioned in this comment, I had to update the controller-manager and kube-rbac-proxy sccs in order to fix the warning on openshift:
Warning: would violate PodSecurity "restricted:v1.24": allowPrivilegeEscalation != false (container "kube-rbac-proxy" must set securityContext.allowPrivilegeEscalation=false), unrestricted capabilities (containers "kube-rbac-proxy", "manager" must set securityContext.capabilities.drop=["ALL"]), seccompProfile (pod or containers "kube-rbac-proxy", "manager" must set securityContext.seccompProfile.type to "RuntimeDefault" or "Localhost")
PR acceptance criteria:
Documentation
How to test changes / Special notes to the reviewer: