-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release changes for OLM validation #49
Release changes for OLM validation #49
Conversation
Skipping CI for Draft Pull Request. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #49 +/- ##
==========================================
+ Coverage 22.72% 25.90% +3.17%
==========================================
Files 23 25 +2
Lines 1307 1444 +137
==========================================
+ Hits 297 374 +77
- Misses 995 1049 +54
- Partials 15 21 +6
☔ View full report in Codecov by Sentry. |
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
…esList CR status field Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
1bb66e0
to
c904e1c
Compare
/retest |
The registry operator also requires its own cert-manager which is not supported by OLM due to it having its own cert management: https://olm.operatorframework.io/docs/advanced-tasks/adding-admission-and-conversion-webhooks/#certificate-authority-requirements Currently investigating a workaround to operator-framework/operator-lifecycle-manager#1805. |
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
…w feedback for setting state conditions Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Update: It seems after reviewing this more that issue here is that if we were doing any of the following it would not work with OLM's cert management:
We are not currently doing these, only using |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnmcollier, kim-tsao, michael-valdron The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* add missing spec and status descriptors Signed-off-by: Michael Valdron <mvaldron@redhat.com> * missing webhook service port added to crd patches Signed-off-by: Michael Valdron <mvaldron@redhat.com> * add conditions list to ClusterDevfileRegistriesList & DevfileRegistriesList CR status field Signed-off-by: Michael Valdron <mvaldron@redhat.com> * add conditions list to DevfileRegistry CR status field Signed-off-by: Michael Valdron <mvaldron@redhat.com> * update scorecard-test image to v1.28.0 Signed-off-by: Michael Valdron <mvaldron@redhat.com> * capability level set to 'Basic Install' or level 1 Signed-off-by: Michael Valdron <mvaldron@redhat.com> * remove unnecessary CHANGELOG Signed-off-by: Michael Valdron <mvaldron@redhat.com> * bump release number Signed-off-by: Michael Valdron <mvaldron@redhat.com> * update channels to beta Signed-off-by: Michael Valdron <mvaldron@redhat.com> * minKubeVersion added Signed-off-by: Michael Valdron <mvaldron@redhat.com> * add license headers script Signed-off-by: Michael Valdron <mvaldron@redhat.com> * update license header under boilerplate and generated source files Signed-off-by: Michael Valdron <mvaldron@redhat.com> * update license headers under controller source and revisions to review feedback for setting state conditions Signed-off-by: Michael Valdron <mvaldron@redhat.com> * update license headers in api source files Signed-off-by: Michael Valdron <mvaldron@redhat.com> * update license headers in pkg source files Signed-off-by: Michael Valdron <mvaldron@redhat.com> * update license headers in integration testing source files Signed-off-by: Michael Valdron <mvaldron@redhat.com> * update license header in main.go source file Signed-off-by: Michael Valdron <mvaldron@redhat.com> --------- Signed-off-by: Michael Valdron <mvaldron@redhat.com> Signed-off-by: thepetk <thepetk@gmail.com>
Please specify the area for this PR
registry operator
What does does this PR do / why we need it:
Changes to fix failing OLM validation test cases, required for OperatorHub publication (devfile/api#1211).
Additional changes include:
CHANGELOG
in favor of using the built-in GitHub release pages that can generate this contentaddlicense.sh
script to insert license headers into new source filesWhich issue(s) this PR fixes:
Fixes #?
fixes devfile/api#1251
PR acceptance criteria:
Change LogAre all your changes documented under the upcoming release entry?Documentation
How to test changes / Special notes to the reviewer: