Fix registry viewer host alias resolution

[kim-tsao]

Please specify the area for this PR

What does does this PR do / why we need it:

• Removes the configmap and volume mounts to pick up the ENV variables for the registry-viewer since this never worked
• Environment variables are specified in the deployment spec and updated if there is a patch
• Added a new DevfileRegistry controller test case with supported test environment types:
  • The controller test is limited to just CRD creation and updates since we can't rely on a successful status update. This depends on a valid DevfileRegistry route being created and resolved. We may want to consider mocking this in the future.
  • Added a local Route CRD similar to what HAS did in order to get the tests to recognize this kind

Which issue(s) this PR fixes:
devfile/api#1028

Fixes #?

PR acceptance criteria:

• Change Log

  • Are all your changes documented under the upcoming release entry?

• Test Coverage

  • Are your changes sufficiently tested, and are any applicable test cases added or updated to cover your changes?
    • Manually tested by deploying on a local cluster and verifying the FQDN in the viewer gets updated.
    • Updated deployment (changed other properties like the write key) and verified the ENV var got properly updated (while FQDN remained unchanged)

• Gosec scans

  • Fix all MEDIUM and higher findings and/or annotate a finding per gosec instructions: https://github.com/securego/gosec#annotating-code to address why a finding is not a security issue

Documentation

• Does the registry operator documentation need to be updated with your changes?

How to test changes / Special notes to the reviewer:

[codecov]

Codecov Report

Patch coverage has no change and project coverage change: +3.14% 🎉

Comparison is base (46fe9e0) 22.72% compared to head (20eeb41) 25.86%.
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #51      +/-   ##
==========================================
+ Coverage   22.72%   25.86%   +3.14%     
==========================================
  Files          23       25       +2     
  Lines        1307     1415     +108     
==========================================
+ Hits          297      366      +69     
- Misses        995     1026      +31     
- Partials       15       23       +8     

Files Changed	Coverage Δ
controllers/devfileregistry_controller.go	0.00% <0.00%> (ø)
controllers/ensure.go	0.00% <ø> (ø)
controllers/update.go	0.00% <0.00%> (ø)
pkg/registry/deployment.go	0.00% <ø> (ø)

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[michael-valdron]

• Change Log
  • Are all your changes documented under the upcoming release entry?

Removed since #49 was merged.

• Does the registry operator documentation need to be updated with your changes?

No documentation changes needed.

[michael-valdron]

Ran the manager build of this branch on both OpenShift (crc) and Kubernetes (minikube), the changes fixes this bug on both! Just left a few minor feedback comments.

[michael-valdron]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kim-tsao, michael-valdron

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [michael-valdron]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment