-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update index server build scripts and deployment #147
Conversation
Codecov ReportBase: 42.88% // Head: 43.92% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #147 +/- ##
==========================================
+ Coverage 42.88% 43.92% +1.03%
==========================================
Files 6 6
Lines 991 1020 +29
==========================================
+ Hits 425 448 +23
- Misses 525 530 +5
- Partials 41 42 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
20abe3c
to
587e6d2
Compare
Need to publish a PR under devfile/registry with changes needed to dispatch registry deployment from here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Took a look at this yesterday, left one comment here:
blocked by devfile/registry#144 |
e351e12
to
6540567
Compare
devfile/registry#144 has been merged and no longer blocks this PR @johnmcollier ready for review |
…registry-viewer docker image building removed. Signed-off-by: Michael Valdron <mvaldron@redhat.com>
…ce copying and include static registry-viewer build with export. Signed-off-by: Michael Valdron <mvaldron@redhat.com>
…-viewer web server service. Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
…build Signed-off-by: Michael Valdron <mvaldron@redhat.com>
…s and file directory from index server build. Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
…er proxy added, removed old registry viewer static routes. Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
…hart. Signed-off-by: Michael Valdron <mvaldron@redhat.com>
…yment and new headed deployment changes. Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
…rror handler. Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
6540567
to
2aa95c8
Compare
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
…ate. Signed-off-by: Michael Valdron <mvaldron@redhat.com>
b99dd45
to
e41c199
Compare
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnmcollier, michael-valdron The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Please specify the area for this PR
registry index server
CI
What does does this PR do / why we need it:
Provides the following changes:
GET /viewer
proxy routeWhich issue(s) this PR fixes:
Fixes #?
part of devfile/api#747
fixes devfile/api#977
PR acceptance criteria:
Documentation (WIP)
How to test changes / Special notes to the reviewer:
Blocked by devfile/devfile-web#51, needs theNo longer blockingquay.io/devfile/registry-viewer:next
image to be published for testing to work.