Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index server build scripts and deployment #147

Merged
merged 23 commits into from
Nov 22, 2022

Conversation

michael-valdron
Copy link
Member

@michael-valdron michael-valdron commented Oct 24, 2022

Please specify the area for this PR

registry index server
CI

What does does this PR do / why we need it:

Provides the following changes:

  • Headless mode added to index server (does not include or expect to include registry viewer)
  • Base index server image build no longer includes and no longer launches web server for registry viewer
  • Helm chart updated to include new registry viewer image, container setup, headless mode, and removes old registry viewer resources
  • Error handling added for GET /viewer proxy route
  • README docs updated to include these changes

Which issue(s) this PR fixes:

Fixes #?

part of devfile/api#747
fixes devfile/api#977

PR acceptance criteria:

  • Test Coverage
    • Are your changes sufficiently tested, and are any applicable test cases added or updated to cover your changes?

Documentation (WIP)

How to test changes / Special notes to the reviewer:

Blocked by devfile/devfile-web#51, needs the quay.io/devfile/registry-viewer:next image to be published for testing to work. No longer blocking

@codecov
Copy link

codecov bot commented Oct 24, 2022

Codecov Report

Base: 42.88% // Head: 43.92% // Increases project coverage by +1.03% 🎉

Coverage data is based on head (07c5525) compared to base (f16affc).
Patch coverage: 63.88% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #147      +/-   ##
==========================================
+ Coverage   42.88%   43.92%   +1.03%     
==========================================
  Files           6        6              
  Lines         991     1020      +29     
==========================================
+ Hits          425      448      +23     
- Misses        525      530       +5     
- Partials       41       42       +1     
Impacted Files Coverage Δ
index/server/pkg/server/index.go 9.02% <0.00%> (ø)
index/server/pkg/server/endpoint.go 36.78% <71.42%> (+1.60%) ⬆️
index/server/pkg/util/util.go 65.66% <100.00%> (+1.73%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@michael-valdron
Copy link
Member Author

Need to publish a PR under devfile/registry with changes needed to dispatch registry deployment from here.

Copy link
Member

@johnmcollier johnmcollier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took a look at this yesterday, left one comment here:

deploy/chart/devfile-registry-headless/README.md Outdated Show resolved Hide resolved
@michael-valdron michael-valdron marked this pull request as ready for review November 8, 2022 17:24
@openshift-ci openshift-ci bot requested a review from elsony November 8, 2022 17:24
@michael-valdron
Copy link
Member Author

blocked by devfile/registry#144

@michael-valdron
Copy link
Member Author

devfile/registry#144 has been merged and no longer blocks this PR

@johnmcollier ready for review

…registry-viewer docker image building removed.

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
…ce copying and include static registry-viewer build with export.

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
…-viewer web server service.

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
…build

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
…s and file directory from index server build.

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
…er proxy added, removed old registry viewer static routes.

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
…hart.

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
…yment and new headed deployment changes.

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
…rror handler.

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
index/server/Dockerfile Outdated Show resolved Hide resolved
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
…ate.

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
README.md Outdated Show resolved Hide resolved
deploy/chart/devfile-registry/templates/deployment.yaml Outdated Show resolved Hide resolved
deploy/chart/devfile-registry/values.yaml Outdated Show resolved Hide resolved
deploy/chart/devfile-registry/templates/deployment.yaml Outdated Show resolved Hide resolved
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 21, 2022
@openshift-ci
Copy link

openshift-ci bot commented Nov 21, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnmcollier, michael-valdron

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 21, 2022
@michael-valdron michael-valdron merged commit 95f8575 into devfile:main Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
2 participants