-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Probe changes in helm chart template #159
Conversation
Codecov ReportBase: 43.20% // Head: 43.20% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #159 +/- ##
=======================================
Coverage 43.20% 43.20%
=======================================
Files 6 6
Lines 1037 1037
=======================================
Hits 448 448
Misses 546 546
Partials 43 43 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
c51a8e3
to
3225088
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kim-tsao, michael-valdron The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
blocked by devfile/api#1020 |
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
3225088
to
c5b999d
Compare
New changes are detected. LGTM label has been removed. |
rebased and unblocked |
Signed-off-by: Michael Valdron mvaldron@redhat.com
Please specify the area for this PR
registry
What does does this PR do / why we need it:
Updates the probing in the helm chart deployment template to ensure the registry index server is ready before launching the registry viewer.
Which issue(s) this PR fixes:
Fixes #?
part of devfile/api#1019
PR acceptance criteria:
Documentation (WIP)
How to test changes / Special notes to the reviewer: