Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Probe changes in helm chart template #159

Merged
merged 1 commit into from
Feb 6, 2023

Conversation

michael-valdron
Copy link
Member

Signed-off-by: Michael Valdron mvaldron@redhat.com

Please specify the area for this PR

registry

What does does this PR do / why we need it:

Updates the probing in the helm chart deployment template to ensure the registry index server is ready before launching the registry viewer.

Which issue(s) this PR fixes:

Fixes #?

part of devfile/api#1019

PR acceptance criteria:

  • Test Coverage
    • Are your changes sufficiently tested, and are any applicable test cases added or updated to cover your changes?

Documentation (WIP)

How to test changes / Special notes to the reviewer:

@codecov
Copy link

codecov bot commented Feb 3, 2023

Codecov Report

Base: 43.20% // Head: 43.20% // No change to project coverage 👍

Coverage data is based on head (c5b999d) compared to base (a2825b5).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #159   +/-   ##
=======================================
  Coverage   43.20%   43.20%           
=======================================
  Files           6        6           
  Lines        1037     1037           
=======================================
  Hits          448      448           
  Misses        546      546           
  Partials       43       43           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@michael-valdron michael-valdron force-pushed the probing-fix branch 2 times, most recently from c51a8e3 to 3225088 Compare February 6, 2023 16:27
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 6, 2023
@openshift-ci
Copy link

openshift-ci bot commented Feb 6, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kim-tsao, michael-valdron
Once this PR has been reviewed and has the lgtm label, please assign maysunfaisal for approval by writing /assign @maysunfaisal in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@michael-valdron
Copy link
Member Author

blocked by devfile/api#1020

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 6, 2023
@openshift-ci
Copy link

openshift-ci bot commented Feb 6, 2023

New changes are detected. LGTM label has been removed.

@michael-valdron
Copy link
Member Author

rebased and unblocked

@michael-valdron michael-valdron merged commit 5c01f60 into devfile:main Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants