Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No startupProbe if in headless mode #162

Merged
merged 1 commit into from
Feb 10, 2023

Conversation

michael-valdron
Copy link
Member

Signed-off-by: Michael Valdron mvaldron@redhat.com

Please specify the area for this PR

registry

What does does this PR do / why we need it:

This change includes a required if block in the helm chart deployment template for headless mode which omits the startupProbe in the registry index server deployment which probes the registry viewer. This change was missing from #159.

Which issue(s) this PR fixes:

Fixes #?

PR acceptance criteria:

  • Test Coverage
    • Are your changes sufficiently tested, and are any applicable test cases added or updated to cover your changes?

Documentation (WIP)

How to test changes / Special notes to the reviewer:

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 10, 2023
@openshift-ci
Copy link

openshift-ci bot commented Feb 10, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kim-tsao, michael-valdron
Once this PR has been reviewed and has the lgtm label, please assign maysunfaisal for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Feb 10, 2023

Codecov Report

Base: 43.20% // Head: 43.20% // No change to project coverage 👍

Coverage data is based on head (8509459) compared to base (5c01f60).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #162   +/-   ##
=======================================
  Coverage   43.20%   43.20%           
=======================================
  Files           6        6           
  Lines        1037     1037           
=======================================
  Hits          448      448           
  Misses        546      546           
  Partials       43       43           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@michael-valdron michael-valdron merged commit 4eaedcc into devfile:main Feb 10, 2023
@michael-valdron michael-valdron deleted the probing-fix branch February 10, 2023 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
2 participants