New Icon: stackblitz (Original) #1954
Conversation
* Fix build icons workflow * Moving Build Icons to Ubuntu machine
There was a problem hiding this comment.
This file shouldn't be changed. The reason it's changed here is since you based your branch on the master branch instead of the develop branch.
To fix this, simply create a new branch based on develop (git checkout develop && git pull && git checkout -b new_brannch_name), then apply your changes to that branch.
| "FullStack Development Online", | ||
| "online ide" |
There was a problem hiding this comment.
| "FullStack Development Online", | |
| "online ide" | |
| "Online IDE" |
There was a problem hiding this comment.
This icon can be simplified, so that it contains only one path. See this tutorial on how to unify paths in inkscape: #1306 (comment).
After that the icon can be optimized using SVGOMG: #1306 (comment)
Once the paths are unified, and the icon is optimized, it can also be a plain Icon. To do this simply add an alias object to devicon.json
| "original" | ||
| ], | ||
| "font": [ | ||
| "plain" |
There was a problem hiding this comment.
There is no plain icon here. Since the original icon can be made to fit the requirements for plain icons, this can be changed to original, once my suggestions for stackblitz-original.svg have been implemented
| ] | ||
| }, | ||
| "color": "#587dbd", | ||
| "aliases": ["stack-blitz"] |
There was a problem hiding this comment.
This is not what the aliases object is used for. Please read see the wiki for more info: on updating devicon.json: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60
| "aliases": [] | ||
| }, | ||
| { | ||
| "name": "stackblitz", |
There was a problem hiding this comment.
Add missing altnames
| "name": "stackblitz", | |
| "name": "stackblitz", | |
| "altnames": [], |
Double check these details before you open a PR
developbranch.devicon.jsonfile as seen hereThis PR closes NONE
fixes #1953
Link to prove your SVG is correct and up-to-date.
https://github.com/stackblitz/core