Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new icon: stackblitz (original, original-wordmark, plain-wordmark, line, line-wordmark) #1964

Merged
merged 17 commits into from
Apr 23, 2024
Merged

new icon: stackblitz (original, original-wordmark, plain-wordmark, line, line-wordmark) #1964

merged 17 commits into from
Apr 23, 2024

Conversation

kalkeshwar
Copy link

@kalkeshwar kalkeshwar commented Oct 31, 2023 •
edited
Loading

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes #1953

Link to prove your SVG is correct and up-to-date.

https://github.com/stackblitz/core

@Snailedlt Snailedlt changed the title feat:added stackblitz icon new icon: stackblitz (original) Oct 31, 2023
@Snailedlt Snailedlt added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Oct 31, 2023
@Gautam25Raj
Copy link
Contributor

Gautam25Raj commented Oct 31, 2023 •
edited
Loading

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes NONE

fixes #1954

Link to prove your SVG is correct and up-to-date.

https://github.com/stackblitz/core

This PR fixes issue #1953
Update your PR

Snailedlt
Snailedlt requested changes Oct 31, 2023
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

devicon.json looks good for the most part.
The stackblitz-original.svg icon needs to be replaced with an actual SVG though. See my suggestions below for more info.

Oh and if you could make changes to this PR instead of creating a new one, that would make reviewing any changes much easier for us :)

icons/stackblitz/stackblitz-original.svg Outdated Show resolved Hide resolved
devicon.json Outdated Show resolved Hide resolved
devicon.json Outdated Show resolved Hide resolved
Gautam25Raj
Gautam25Raj suggested changes Oct 31, 2023
View reviewed changes
devicon.json Outdated Show resolved Hide resolved
kalkeshwar and others added 3 commits October 31, 2023 21:31
@kalkeshwar @Gautam25Raj
Update devicon.json
3f4c17c 
Co-authored-by: Gautam Raj <63155224+Gautam25Raj@users.noreply.github.com>
@kalkeshwar @Gautam25Raj
Update icons/stackblitz/stackblitz-original.svg
162eaf2 
Co-authored-by: Gautam Raj <63155224+Gautam25Raj@users.noreply.github.com>
@kalkeshwar @Snailedlt
Update devicon.json
1fa9fd7 
Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
@Gautam25Raj
Copy link
Contributor

image

Icon look fine to me. What are your thought on it @Snailedlt ?

@kalkeshwar
Copy link
Author

@Snailedlt please review and merge the PR

@kalkeshwar
Copy link
Author

@Snailedlt , @lunatic-fox please review and merge the PR and add label as hacktoberfest-accepted

Snailedlt
Snailedlt requested changes Oct 31, 2023
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kalkeshwar The logo looks very nice!
Now there's just some fixes to devicon.json needed... and optionally you could add a plain-wordmark and an original-wordmark version to the PR if you want.

Sidenote

After looking around I was able to find some official logos on their github repo:

plain_wordmark
https://github.com/stackblitz/viteconf/blob/ce041ba6504fb317eab71d3471bed2a83e56d13f/public/images/logos/stackblitz-logo.svg

original-wordmark
https://github.com/stackblitz/viteconf/blob/ce041ba6504fb317eab71d3471bed2a83e56d13f/public/images/logos/stackblitz.svg

This took a while for me to find, so in the future please provide links to the official logos :)

devicon.json Outdated Show resolved Hide resolved
@Snailedlt Snailedlt closed this Oct 31, 2023
@Snailedlt Snailedlt reopened this Oct 31, 2023
@kalkeshwar
Copy link
Author

@Snailedlt , please have a look and review the changes.

Snailedlt
Snailedlt reviewed Oct 31, 2023
View reviewed changes
devicon.json Outdated Show resolved Hide resolved
@Snailedlt Snailedlt added the hacktoberfest-accepted Accepted to be counted towards Hacktoberfest label Oct 31, 2023
Snailedlt
Snailedlt reviewed Oct 31, 2023
View reviewed changes
devicon.json Outdated Show resolved Hide resolved
Snailedlt
Snailedlt previously approved these changes Oct 31, 2023
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✔️
Thank you for the contribution! 🙇

@Snailedlt Snailedlt requested review from a team, ConX, weh and canaleal and removed request for a team October 31, 2023 19:28
Snailedlt
Snailedlt previously approved these changes Nov 1, 2023
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added missing newline at EOF, and also the fill color of the icon

Snailedlt
Snailedlt requested changes Nov 1, 2023
View reviewed changes
devicon.json Outdated Show resolved Hide resolved
@kalkeshwar @Snailedlt
Update devicon.json
0d6e1b2 
Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
Snailedlt
Snailedlt previously approved these changes Nov 1, 2023
View reviewed changes
@canaleal
Copy link
Member

canaleal commented Nov 4, 2023 •
edited by Snailedlt
Loading

Hey @kalkeshwar, I can't commit to the branch directly, so I'll add the other versions of the SVGs below:

Original-wordmark:

<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 128 128"><path fill="#1389fd" d="M7.8811 66.4023H0l14.4069-15.6084L10.5288 61.6h7.8811L4.0023 77.2061Z"/><path d="m31.1413 68.2179 2.5417-1.4857c.5387 1.4004 1.594 2.3048 3.4698 2.3048 1.7874 0 2.4122-.7543 2.4122-1.5947 0-1.12-1.0119-1.5505-3.2541-2.1973-2.3048-.6682-4.5448-1.6374-4.5448-4.5029 0-2.8434 2.3688-4.4815 4.9547-4.4815 2.4777 0 4.3733 1.2716 5.3859 3.382l-2.499 1.4439c-.5387-1.1421-1.357-1.939-2.887-1.939-1.2502 0-1.9824.6468-1.9824 1.5077 0 .9265.5813 1.4218 2.8663 2.1113 2.3916.7543 4.9333 1.5512 4.9333 4.6316 0 2.822-2.262 4.5463-5.472 4.5463-3.0811.0007-5.1063-1.4857-5.9246-3.7265zm16.6134-4.6743v4.4808c0 1.1626.8403 1.1847 2.4343 1.0979v2.5219c-3.8995.4305-5.2153-.7116-5.2153-3.6198v-4.4808h-1.8735V60.871h1.8735v-2.1753l2.7802-.8404v3.0157h2.4343v2.6727zM62.793 60.871v10.7733h-2.7786v-1.2716c-.7756.9691-1.939 1.5725-3.5116 1.5725-2.8656 0-5.235-2.4777-5.235-5.6876 0-3.2099 2.3694-5.6884 5.235-5.6884 1.5725 0 2.7367.6035 3.5116 1.5726v-1.2716h2.7786zm-2.7786 5.3866c0-1.8095-1.2709-3.0377-2.9943-3.0377-1.7021 0-2.9737 1.2282-2.9737 3.0377s1.2716 3.037 2.9737 3.037c1.7234.0007 2.9943-1.2275 2.9943-3.037zm4.7428 0c0-3.2099 2.4122-5.6884 5.6869-5.6884 2.1112 0 3.9436 1.1208 4.8259 2.7795l-2.3916 1.4004c-.4305-.883-1.3577-1.4439-2.4564-1.4439-1.6594 0-2.8869 1.2275-2.8869 2.9517 0 1.7013 1.2275 2.9295 2.8869 2.9295 1.1208 0 2.0465-.538 2.4777-1.4217l2.413 1.379c-.9258 1.6808-2.7581 2.8015-4.8694 2.8015-3.2739 0-5.686-2.4777-5.686-5.6876zm18.723 5.3867-3.9207-4.8907v4.8907H76.781V56.563h2.7786v9.0484l3.706-4.7405h3.3173l-4.3307 5.3219 4.4602 5.4506h-3.232zm15.837-4.3741c0 2.5851-2.0899 4.3733-4.6963 4.3733h-6.3985V56.563h5.9466c2.5418 0 4.5882 1.7235 4.5882 4.2439 0 1.2921-.5386 2.3055-1.4217 3.0163 1.2069.6896 1.9817 1.8743 1.9817 3.4469zm-8.1226-7.9284v3.3181h2.9737c.9265 0 1.616-.7124 1.616-1.6602 0-.9478-.6682-1.6586-1.616-1.6586h-2.9737zm5.171 7.7349c0-1.0126-.7322-1.7661-1.7447-1.7661h-3.4263v3.5543h3.4263c1.0133-.0008 1.7447-.7543 1.7447-1.7882zm4.7642-11.1604h2.7787v15.728h-2.7787zm4.9996 1.9604c0-.9265.7756-1.7235 1.7014-1.7235.9478 0 1.7234.797 1.7234 1.7235 0 .9264-.7756 1.7013-1.7234 1.7013-.9258.0008-1.7014-.7749-1.7014-1.7013zm.323 2.9943h2.7787v10.7733h-2.7786zm9.05 2.6727v4.4808c0 1.1626.8404 1.1847 2.4343 1.0979v2.5219c-3.8995.4305-5.2137-.7116-5.2137-3.6198v-4.4808h-1.8743V60.871h1.8743v-2.1753l2.7786-.8404v3.0157h2.4343v2.6727zM128 69.037v2.6072h-8.5097v-1.8537l4.5455-6.3116h-4.3299v-2.608h8.0785v1.8537l-4.5669 6.3124z"/></svg>

Plain-wordmark:

<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 128 128"><path fill="#1389fd" d="M14.4063 50.793 0 66.4023h7.8809L4.0019 77.207l14.4083-15.6074h-7.8809l3.877-10.8066zm86.7246 5.123v15.7285h2.7773V55.916h-2.7773zm6.6992.2363c-.9257 0-1.7012.7982-1.7012 1.7247 0 .9264.7755 1.7019 1.7012 1.7011.9478 0 1.7246-.7747 1.7246-1.7011 0-.9265-.7768-1.7247-1.7246-1.7247zm-71.1094.1075c-2.5859 0-4.955 1.639-4.955 4.4824 0 2.8655 2.24 3.8338 4.5448 4.502 2.2423.6468 3.254 1.0772 3.254 2.1972 0 .8404-.6247 1.5957-2.4122 1.5957-1.8758 0-2.93-.9043-3.4687-2.3047l-2.543 1.4864c.8183 2.2407 2.8447 3.7273 5.9258 3.7265 3.21 0 5.4707-1.7248 5.4707-4.5469 0-3.0803-2.54-3.8785-4.9316-4.6328-2.285-.6895-2.8672-1.1848-2.8672-2.1113 0-.861.7321-1.5078 1.9824-1.5078 1.53 0 2.348.7973 2.8867 1.9394l2.5-1.4433c-1.0125-2.1105-2.909-3.3828-5.3867-3.3828zm40.0605.3027v15.082h2.7793V66.754l3.92 4.8887h3.2324l-4.461-5.4492 4.3301-5.3223h-3.3164l-3.705 4.7402v-9.0488h-2.7793zm11.4415 0v15.08h6.3984c2.6065 0 4.6953-1.7878 4.6953-4.373 0-1.5725-.7736-2.7577-1.9805-3.4472.883-.7109 1.422-1.7235 1.422-3.0157 0-2.5203-2.0463-4.2441-4.588-4.2441h-5.9472zm-40.4688 1.293-2.7793.8398v2.1758h-1.875v2.6719h1.875v4.4804c0 2.9082 1.3154 4.0516 5.2149 3.6211V69.123c-1.594.0869-2.4356.0631-2.4356-1.0996V63.543h2.4336v-2.672h-2.4336v-3.0155zm67.748 0-2.7792.8398v2.1758h-1.873v2.6719h1.873v4.4804c0 2.9082 1.3154 4.0516 5.2148 3.6211V69.123c-1.5939.0869-2.4356.0631-2.4356-1.0996V63.543h2.4337v-2.672h-2.4337v-3.0155zm-24.3066 1.4863h2.9727c.9478 0 1.6172.7104 1.6172 1.6582 0 .9478-.6908 1.6602-1.6172 1.6602h-2.9727v-3.3184zM56.502 60.5684c-2.8656 0-5.2344 2.4795-5.2344 5.6894 0 3.21 2.3688 5.6875 5.2344 5.6875 1.5725 0 2.736-.6031 3.5117-1.5723v1.2715h2.7793V60.8691h-2.7793v1.2735c-.7749-.9692-1.9392-1.5742-3.5117-1.5742zm13.9414 0c-3.2747 0-5.6856 2.4795-5.6856 5.6894 0 3.21 2.4117 5.6875 5.6856 5.6875 2.1112 0 3.9434-1.12 4.8691-2.8008l-2.4121-1.3808c-.4312.8838-1.3578 1.4218-2.4785 1.4218-1.6595 0-2.8867-1.2283-2.8867-2.9296 0-1.7242 1.2272-2.9512 2.8867-2.9512 1.0986 0 2.0265.5603 2.457 1.4433l2.3906-1.4003c-.8823-1.6587-2.7149-2.7793-4.8261-2.7793zm36.0097.3027v10.7734h2.7774V60.8711h-2.7774zm13.252 0v2.6074h4.33l-4.5449 6.3125v1.8535H128v-2.6074h-4.7832l4.5684-6.3125v-1.8535h-8.0801zm-62.6856 2.3496c1.7235 0 2.9942 1.2276 2.9942 3.0371s-1.2707 3.0379-2.9942 3.0371c-1.702 0-2.9726-1.2276-2.9726-3.037 0-1.8096 1.2705-3.0372 2.9726-3.0372zm34.1758 2.0898h3.4258c1.0126 0 1.7441.7531 1.7441 1.7657 0 1.0339-.7308 1.7883-1.7441 1.789h-3.4258v-3.5547z"/></svg>

Line:

<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 128 128"><path d="M91.8877 0 19.0635 75.7324h38.0938L35.29 127.459l.8203.541 72.8262-75.7324H70.8428L92.71.541Zm-1.1504 2.6406L69.335 53.2676h37.252l-69.3224 72.0898 21.3985-50.625h-37.25z"/></svg>

Line-wordmark:

<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 128 128"><path d="M14.9941 50.623 0 66.871h8.209l-3.588 9.9981.838.5079 14.998-16.2461h-8.211l3.586-10zm-.9336 2.4864-3.2363 9.0215h7.3477L6.3945 74.8906l3.2364-9.0195H2.2832Zm86.4141 2.4101V72.047h3.7422V55.5195Zm7.1133.2325c-1.2012 0-2.1797 1.0095-2.1797 2.203 0 1.1936.9865 2.1808 2.1797 2.1798 1.2081 0 2.2031-.9857 2.2031-2.1797 0-1.1941-.9868-2.2031-2.2031-2.2031zm-70.1973.1074c-1.382 0-2.716.434-3.7226 1.2754-1.0067.8413-1.668 2.106-1.668 3.6484 0 1.5447.645 2.675 1.5762 3.4258.9312.7508 2.1115 1.1642 3.2695 1.5h.002c1.0976.3166 1.8756.5843 2.3125.8535.437.2692.5371.4317.5371.834 0 .2909-.08.5064-.334.7031-.254.1967-.735.373-1.5468.373-1.691 0-2.478-.7094-2.957-1.955l-.211-.5489-3.379 1.9747.1427.3925c.8746 2.395 3.1178 4.0086 6.3203 4.0079 1.6739 0 3.1395-.4498 4.203-1.3126 1.0637-.8627 1.6974-2.1493 1.6974-3.6757 0-1.6579-.738-2.8129-1.7559-3.5528-1.018-.7399-2.2826-1.1257-3.4629-1.498l-.002-.002h-.0039c-1.1074-.3342-1.7742-.6262-2.1035-.875-.3293-.2489-.3711-.3779-.3711-.7305 0-.2832.1005-.4928.3262-.6719.2256-.179.5999-.3164 1.1308-.3164 1.3366 0 1.9118.595 2.3985 1.627l.2304.4922 3.3399-1.9278-.2012-.418c-1.071-2.232-3.1505-3.623-5.7676-3.623zm39.0469.2988v15.8887h3.7441v-3.9043l3.129 3.9023h11.2382c2.8015 0 5.1347-1.997 5.1347-4.8183 0-1.4984-.7481-2.6475-1.8008-3.4395.7364-.7628 1.25-1.7331 1.25-2.9394 0-2.7587-2.2942-4.6895-5.0293-4.6895h-6.371v15.8086l-4.75-5.8027 4.6816-5.754h-4.5684l-2.914 3.7286v-7.9805zm25.0371.3613h1.7422V71.047h-1.7422zm6.1133.2325c.655 0 1.2031.5679 1.2031 1.203 0 .6352-.5397 1.1798-1.2031 1.1798-.6343.0005-1.1797-.5442-1.1797-1.1797 0-.6357.5532-1.2031 1.1797-1.2031zm-70.1973.1074c2.0947 0 3.6012 1.0362 4.5625 2.6972l-1.5996.9239c-.6105-.9845-1.5108-1.7715-2.9629-1.7715-.7033 0-1.3076.1805-1.752.5332a1.8596 1.8596 0 0 0-.705 1.455c0 .5621.2456 1.135.7676 1.5294.522.3944 1.2697.6867 2.418 1.0332 1.1784.3717 2.3453.7522 3.1699 1.3515.826.6004 1.3437 1.3611 1.3437 2.7442 0 1.2594-.4836 2.2153-1.3281 2.9004-.8445.685-2.0775 1.0879-3.5723 1.0879-2.6924.0006-4.3682-1.1827-5.1855-2.9903l1.7304-1.0097c.6666 1.224 1.778 2.1289 3.5391 2.1289.9527 0 1.6628-.1985 2.1582-.582.4954-.3836.7227-.9556.7227-1.4942 0-.7033-.398-1.3062-1.0137-1.6856-.6158-.3793-1.4427-.641-2.5586-.9629-1.1172-.3239-2.1786-.719-2.9219-1.3183-.7432-.5992-1.205-1.3623-1.205-2.6465 0-1.2646.5096-2.2115 1.3105-2.8809.801-.6694 1.9113-1.043 3.082-1.043zm40.0469.2988h1.7441v13.8887h-1.7441zm11.295 0h5.371c2.283 0 4.0293 1.472 4.0293 3.6895 0 1.1366-.4502 1.9692-1.2187 2.5878l-.5704.459.6368.3633c1.057.604 1.703 1.5803 1.703 2.9688 0 2.2826-1.7903 3.8183-4.1347 3.8183h-5.8164zm-39.9493.1035-.6445.1934-3.0996.9375v2.0176h-1.8516v3.6386h1.8516v3.9219c0 1.5108.3637 2.7184 1.3359 3.4277.9722.7093 2.3884.863 4.3672.6446l.4453-.0489v-3.4648l-.5273.0293c-.7795.0425-1.3538.031-1.6036-.0547-.1249-.0428-.1613-.076-.1972-.1328-.036-.0569-.0762-.1738-.0762-.4004v-3.9219h2.4023v-3.6386h-2.4023zm66.879 0-.6446.1934-3.0996.9375v2.0176h-1.8496v3.6386h1.8496v3.9219c0 1.5108.3637 2.7184 1.3359 3.4277.9722.7093 2.3884.863 4.3672.6446l.4453-.0489v-3.4648l-.5273.0293c-.7795.0425-1.3538.031-1.6035-.0547-.125-.0428-.1614-.076-.1973-.1328-.036-.0569-.0762-.1738-.0762-.4004v-3.9219h2.4023v-3.6386h-2.4023zm-67.879 1.3457v2.8028h2.4023v1.6386h-2.4023v4.9219c0 .3472.0614.666.2305.9336.169.2677.4392.4491.7187.545.4103.1406.932.0972 1.4551.078v1.5254c-1.5672.117-2.647-.0394-3.2246-.4609-.6395-.4665-.9238-1.261-.9238-2.621v-4.922h-1.8516v-1.6386h1.8516v-2.2754Zm66.879 0v2.8028h2.4022v1.6386h-2.4023v4.9219c0 .3472.0614.666.2305.9336.169.2677.4392.4491.7187.545.4103.1406.932.0972 1.4551.078v1.5254c-1.5662.1168-2.6452-.0396-3.2226-.4609-.6395-.4665-.9258-1.261-.9258-2.621v-4.922h-1.8496v-1.6386h1.8496v-2.2754Zm-23.9962.295v4.2753h3.4356c1.1708 0 2.0957-.9601 2.0957-2.1386 0-1.171-.9103-2.1368-2.0957-2.1368zm1 .998h2.4356c.6858 0 1.0957.4384 1.0957 1.1387 0 .6927-.4374 1.1386-1.0957 1.1386H91.666zm-35.248.211v.1073c-2.8734.2833-5.166 2.789-5.166 6.0098 0 3.4147 2.5491 6.1153 5.666 6.1153 1.2179 0 2.1668-.4401 2.9668-1.041v.744h3.7441V60.4083h-3.7441v.7461c-.8-.6018-1.7484-1.043-2.9668-1.043zm14.2636 0c-3.485 0-6.1132 2.698-6.1132 6.1171 0 3.419 2.629 6.1153 6.1132 6.1153 2.261 0 4.2411-1.2024 5.2442-3.0235l.2363-.4316-3.2715-1.873-.2344.4804c-.3369.6907-1.0498 1.123-1.996 1.123-1.3916 0-2.3497-.9534-2.3497-2.3925 0-1.465.958-2.4141 2.3497-2.4141.9146 0 1.639.4523 1.9765 1.1445l.2363.4844 3.2383-1.8965-.2246-.4238c-.9619-1.8084-2.9441-3.0098-5.205-3.0098zm35.047.2988v11.6367h3.7421V60.4102Zm13.082 0v3.5742h3.7988l-4.0098 5.5703v2.4922H128v-3.5742h-4.2441l4.0312-5.5704v-2.4921zm-61.8926.7011c1.424 0 2.4003.522 3.0761 1.3672l.8907 1.1133v-2.1836h1.7441v9.6387h-1.7441v-2.1797l-.8907 1.1113c-.6765.8453-1.6515 1.3653-3.0761 1.3653-2.5405 0-4.668-2.1926-4.668-5.1153 0-2.9228 2.1276-5.1172 4.668-5.1172zm13.7636 0c1.7187 0 3.1284.8894 3.9786 2.125l-1.502.879c-.5813-.7672-1.447-1.3028-2.498-1.3028-1.8846 0-3.3497 1.4747-3.3497 3.414 0 1.92 1.4647 3.3926 3.3497 3.3926 1.0625 0 1.9354-.5216 2.5195-1.287l1.5137.8671c-.8835 1.2554-2.2947 2.1445-4.0118 2.1445-2.9797 0-5.1132-2.1969-5.1132-5.1152 0-2.9185 2.133-5.1172 5.1132-5.1172zm12.9004.2989h1.9805l-3.8691 4.7558 3.9941 4.879H83.791l-3.918-4.8888Zm23.1465 0h1.7422v9.6367h-1.7422zm13.082 0h6.9766v1.168l-4.9883 6.8945H127v1.5742h-7.4024v-1.17l4.963-6.8925h-4.75zm-62.3808 1.3203c-1.9206 0-3.4356 1.4777-3.4356 3.498s1.515 3.498 3.4356 3.498c1.939.001 3.455-1.4776 3.455-3.498 0-2.0204-1.5163-3.498-3.455-3.498zm0 1c1.464 0 2.455.9456 2.455 2.498 0 1.5523-.9913 2.4988-2.455 2.498-1.4399 0-2.4356-.9457-2.4356-2.498 0-1.5523.9957-2.498 2.4356-2.498zM90.666 64.793v4.5097h3.8828c1.2483-.001 2.2207-1.0094 2.2207-2.2656 0-1.2404-.9733-2.2441-2.2207-2.2441zm1 1h2.8828c.7517 0 1.2207.4852 1.2207 1.2441 0 .785-.4682 1.265-1.2207 1.2656H91.666z"/></svg>

@Snailedlt
Copy link
Collaborator

@canaleal I edited your codeblocks so they're easier to copy. Hope you don't mind :)

@Snailedlt
Copy link
Collaborator

Thanks for providing the code btw :)

weh
weh requested changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@weh weh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stackblitz-original and devicon.json are good as for now. but please add the Versions provided by @canaleal --> #1964 (comment)

This should be no big thing to do.

Thank you :)

@Snailedlt
Add versions suggested by canaleal
2c1dc6f 
>
>
Co-authored-by: canaleal <49886351+canaleal@users.noreply.github.com>
@Snailedlt
Add fill color to line versions
e3d822a
@Snailedlt
fix tags
b329eda
@Snailedlt Snailedlt changed the title new icon: stackblitz (original) new icon: stackblitz (original, original-wordmark, plain-wordmark, line, line-wordmark) Jan 8, 2024
@Snailedlt Snailedlt closed this Jan 8, 2024
@Snailedlt Snailedlt reopened this Jan 8, 2024
Snailedlt
Snailedlt approved these changes Jan 8, 2024
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the suggested icons made by @canaleal, and edited devicon.json to include the new versions, and use valid tags. I also added a fill color to the icon versions that were missing it.

I can't find any flaws now, so to me this is good to merge! ✅
Great work @kalkeshwar and @canaleal! 💯

image
image
image
image
image

weh
weh approved these changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@weh weh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@github-actions GitHub Actions
Copy link
Contributor

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

@canaleal canaleal merged commit c0cb488 into devicons:develop Apr 23, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@canaleal canaleal canaleal approved these changes

@Snailedlt Snailedlt Snailedlt approved these changes

@weh weh weh approved these changes

@ConX ConX Awaiting requested review from ConX ConX was automatically assigned from devicons/devicon__reviewers

@lunatic-fox lunatic-fox Awaiting requested review from lunatic-fox lunatic-fox was automatically assigned from devicons/devicon__reviewers

@Gautam25Raj Gautam25Raj Awaiting requested review from Gautam25Raj

Assignees
No one assigned
Labels
feature:icon Use this label for pull requests when a new icon is ready to be added to the collection hacktoberfest-accepted Accepted to be counted towards Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kalkeshwar @Gautam25Raj @canaleal @Snailedlt @weh