Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update icon: magento (original, original-wordmark, plain-wordmark, line, line-wordmark) #2034

Merged
merged 3 commits into from
Dec 5, 2023
Merged

update icon: magento (original, original-wordmark, plain-wordmark, line, line-wordmark) #2034

merged 3 commits into from
Dec 5, 2023

Conversation

canaleal
Copy link
Member

@canaleal canaleal commented Nov 21, 2023 •
edited
Loading

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR is related to #1998

Link to prove your SVG is correct and up-to-date.

Additional Notes

The magento original-wordmark cannot be used for the font version as it has 2 paths and different fills.
Used the magento orange color #f26322 for the font SVGs.

@canaleal canaleal added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Nov 21, 2023
@canaleal canaleal mentioned this pull request Nov 22, 2023
Closed
weh
weh approved these changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@weh weh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 👍

@weh weh requested review from a team, ConX, Snailedlt and lunatic-fox and removed request for a team November 23, 2023 10:09
lunatic-fox
lunatic-fox approved these changes Dec 2, 2023
View reviewed changes
Copy link
Contributor

@lunatic-fox lunatic-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! 💯
Thank you for this contribution! 🚀
image
image
image
image

@Snailedlt Snailedlt merged commit 110eef8 into devicons:develop Dec 5, 2023
5 checks passed
@lunatic-fox lunatic-fox mentioned this pull request Jan 10, 2024
Merged
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunatic-fox lunatic-fox lunatic-fox approved these changes

@weh weh weh approved these changes

@ConX ConX Awaiting requested review from ConX ConX was automatically assigned from devicons/devicon__reviewers

@Snailedlt Snailedlt Awaiting requested review from Snailedlt Snailedlt was automatically assigned from devicons/devicon__reviewers

Assignees
No one assigned
Labels
feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@canaleal @weh @lunatic-fox @Snailedlt