Build preparation for release v2.16.0 #2105
Conversation
lunatic-fox
commented
Jan 10, 2024
lunatic-fox
commented
Co-authored-by: Snailedlt <Snailedlt@users.noreply.github.com>
bot:build new icons, icomoon.json and devicon.css
Review of the latest fix changesFrom the icons that were fixed only
|
|
If ceylon is the only bug I say we release it now, and do a hotfix later :) |
Me too. I'm gonna just check the other icons and make a proper review now. |
|
There are some issues, but the most important are the ones marked with [HP].
[HP] Icons there are missing in Font versionsHowever they are present in SVG versions. ceylon: [plain-wordmark]
heroku: [original, original-wordmark][HP] Icons there are missing in SVG versionsHowever they are present in Font versions. akka: [plain, plain-wordmark]
alpinejs: [plain, plain-wordmark]
azuredevops: [plain]
azuresqldatabase: [plain]
beats: [plain]
cosmosdb: [plain, plain-wordmark]
dbeaver: [plain]
eclipse: [plain, plain-wordmark]
envoy: [plain, plain-wordmark]
poetry: [plain][LP] Add default colorIcons without a default adonisjs: [original-wordmark]
angular: [plain, plain-wordmark]
apache: [plain, plain-wordmark, line, line-wordmark]
apacheairflow: [plain, plain-wordmark]
apachespark: [plain-wordmark]
apl: [plain]
argo: [plain, plain-wordmark]
astro: [plain, plain-wordmark]
babel: [plain]
bootstrap: [plain, plain-wordmark]
browserstack: [plain, plain-wordmark]
bun: [plain, line]
cairo: [plain, plain-wordmark]
cassandra: [plain, plain-wordmark]
centos: [plain, plain-wordmark]
clarity: [plain, plain-wordmark]
clion: [plain-wordmark]
consul: [plain-wordmark]
couchbase: [plain-wordmark]
datagrip: [plain-wordmark]
dataspell: [plain-wordmark]
djangorest: [plain, plain-wordmark, line, line-wordmark]
dreamweaver: [plain, line]
dynamodb: [plain]
ecto: [plain-wordmark]
eleventy: [plain]
elixir: [plain, plain-wordmark]
embeddedc: [plain, plain-wordmark]
ember: [plain]
figma: [plain]
fsharp: [plain]
gazebo: [plain, plain-wordmark]
gcc: [plain, line]
go: [plain, line]
godot: [plain, plain-wordmark]
goland: [plain-wordmark]
grails: [plain]
groovy: [plain]
grpc: [plain]
hadoop: [plain, plain-wordmark]
hardhat: [plain, plain-wordmark]
haskell: [plain, plain-wordmark]
homebrew: [plain, plain-wordmark, line, line-wordmark]
insomnia: [plain, plain-wordmark]
intellij: [plain-wordmark]
jamstack: [plain-wordmark]
jekyll: [plain, plain-wordmark]
jenkins: [plain, line]
jetbrains: [plain]
jira: [plain, plain-wordmark]
jiraalign: [plain, plain-wordmark]
julia: [plain, plain-wordmark]
jupyter: [plain, plain-wordmark]
kdeneon: [plain]
keras: [plain, plain-wordmark, line, line-wordmark]
knexjs: [plain-wordmark]
ktor: [plain-wordmark]
labview: [plain, plain-wordmark]
linkedin: [plain, plain-wordmark]
llvm: [plain]
materializecss: [plain]
matlab: [plain]
maven: [plain, plain-wordmark]
neo4j: [plain, plain-wordmark]
neovim: [plain, plain-wordmark, line, line-wordmark]
netlify: [plain, plain-wordmark]
ngrx: [plain]
nimble: [plain]
nomad: [plain-wordmark]
norg: [plain]
notion: [plain, line]
nuxtjs: [plain, plain-wordmark]
ocaml: [plain, plain-wordmark]
opencv: [plain, plain-wordmark]
openstack: [plain-wordmark]
perl: [plain]
phoenix: [plain-wordmark]
php: [plain]
phpstorm: [plain-wordmark]
playwright: [plain]
plotly: [plain, plain-wordmark]
pnpm: [plain, plain-wordmark]
podman: [plain, plain-wordmark]
polygon: [plain, plain-wordmark]
powershell: [plain]
pycharm: [plain, plain-wordmark]
pypi: [plain, plain-wordmark]
qodana: [plain-wordmark]
rabbitmq: [plain-wordmark]
reach: [plain]
readthedocs: [line]
realm: [plain, plain-wordmark]
renpy: [plain]
rider: [plain-wordmark]
rockylinux: [plain-wordmark]
rubymine: [plain-wordmark]
scikitlearn: [plain, line]
reactrouter: [plain, plain-wordmark]
solidjs: [plain, plain-wordmark]
spack: [plain]
sqlite: [plain, plain-wordmark]
stackoverflow: [plain, plain-wordmark, line, line-wordmark]
storybook: [plain, plain-wordmark]
supabase: [plain, plain-wordmark]
svelte: [plain, plain-wordmark]
swagger: [plain, plain-wordmark]
swift: [plain, plain-wordmark]
swiper: [original]
tailwindcss: [plain-wordmark]
tauri: [plain, plain-wordmark]
terraform: [plain, plain-wordmark]
thealgorithms: [plain, plain-wordmark]
tomcat: [plain, plain-wordmark]
tortoisegit: [plain, line]
trpc: [plain, plain-wordmark]
ubuntu: [plain, plain-wordmark]
unity: [plain, plain-wordmark, line, line-wordmark]
vagrant: [plain, plain-wordmark]
vala: [plain, plain-wordmark]
vault: [plain-wordmark]
vitejs: [plain]
vitess: [plain, plain-wordmark]
vitest: [plain]
vscode: [plain, plain-wordmark]
wasm: [plain-wordmark]
webstorm: [plain-wordmark]
yaml: [plain]
yarn: [line, line-wordmark]
yii: [plain, plain-wordmark]
yugabytedb: [plain, plain-wordmark]
zig: [plain-wordmark][MP] Different colorsThe color in SVG versions is different of Font versions. azure: [plain, plain-wordmark]
behance: [plain, plain-wordmark]
cloudflare: [plain, plain-wordmark]
cloudflareworkers: [plain, plain-wordmark]
cmake: [plain, plain-wordmark]
couchdb: [plain, plain-wordmark]
css: [plain, plain-wordmark]
dropwizard: [plain]
express: [original, original-wordmark]
fedora: [plain]
githubcodespaces: [plain]
okta: [plain, plain-wordmark]
prolog: [plain, plain-wordmark]
putty: [plain]
scala: [plain, plain-wordmark]
slack: [plain, plain-wordmark]
streamlit: [plain, plain-wordmark]
towergit: [plain, plain-wordmark]
v8: [plain]
vuejs: [plain, plain-wordmark, line, line-wordmark][MP] Not a plain iconIcons that are reference as plain but have more than one color and eventually more than one path in their antdesign: [plain, plain-wordmark]
bamboo: [original, original-wordmark]
bitbucket: [original, original-wordmark]
blender: [original, original-wordmark][LP] Original can be used as plainappwrite: [plain, plain-wordmark]
archlinux: [plain]
arduino: [plain, plain-wordmark]
bash: [plain]
bulma: [original]
cakephp: [plain]
circleci: [plain, plain-wordmark]
codecov: [plain]
codeigniter: [plain, plain-wordmark]
cucumber: [plain, plain-wordmark]
django: [plain, plain-wordmark]
dotnetcore: [plain]
gitter: [plain, plain-wordmark]
graphql: [plain, plain-wordmark]
gulp: [plain]
jest: [plain]
objectivec: [plain][MP] Version referenceThe current reference should be an alias of the new version and the file should be renamed as well.
clojure:
- current: line
new: plain
composer:
- current: line
new: plain
- current: line-wordmark
new: plain-wordmark[MP] MiscellaneousSpecific issues.
helm:
- base: original
alias: plain
- color: [line]
tensorflow:
- add: plain-wordmark
- base: original
alias: plain
- color: [line, line-wordmark]
pyscript:
- current: original-wordmark
new: original
- current: plain-wordmark
new: plain
- color: plain |
|
Great review @lunatic-fox! Imo all of these are MP and lower. We can make a release just fine without fixing them, and then issue hotfixes after the fact. There's just so many features and bugfixes now, that I think it's worth releasing even if we have some issues. |
I still agree! |
Snailedlt
requested review from
a team,
ConX,
weh,
Snailedlt,
canaleal and
Panquesito7
and removed request for
a team
Same here. A release now will be good. |
Completely agree. Let's merge this ASAP. 🚀 |
Agreed, but let's perhaps do that after we make the hotfixes too. It's quite a big change, so we don't want that to stop us from doing more releases |
Panquesito7
added
new release
|
@lunatic-fox When reviewing this locally, you only need to run Some odd artifacting going on with the
|
|
@Snailedlt var gitHubPath = 'devicons/devicon'
var url = 'https://api.github.com/repos/' + gitHubPath + '/tags';
$scope.latestReleaseTagging = 'latest';
$http.get(url).success(function (data) {
if(data.length > 0) {
$scope.latestReleaseTagging = data[0].name;
}
}).error(function () {
console.log('Unable to determine latest release version, fallback to master.')
});
var versionStr = '@' + $scope.latestReleaseTagging;
// ...
if (xhr.status == "404") {
baseUrl = `https://cdn.jsdelivr.net/gh/${gitHubPath}${versionStr}/`
} else {
baseUrl = `/`;
}In the live server there are 473 icons and it addresses to local build icons, in that case, the built font and the |
|
@Snailedlt |
|
@lunatic-fox create another draft release |
I think I fixed the issue now. Check out this PR: https://github.com/Snailedlt/devicon/pull/new/some-small-fixes |
I didn't get it. You mean re-create the branch? |
That's one of the icons that were fixed and |
As long as the fonts and styles are added to the code, and the bugfix PR is added in the PR comment it doesn't really matter much how you do it, but I think the easiest and safest might be to just start the release process from the start again |
Well, I'll stick with the idea of make a commit, since I can do it really fast and since it did fix some errors. However, if anything different happen we can revert it and create it again. |
Hmmm, the issue seems to be that they aren't added to icomoon, so icomoon.json and devicon-base.css don't have the updated version names. See heroku for example: Notice how the versions here are I wonder if Heroku could be fixed by just merging in an empty PR with the title |
|
Fix commit done! 🔧 |
|
Great! I'll re-review it then :D |
|
One quick sidenote (so I don't forget) is that Ideally we would fix it right away, but since that would mean even more waiting before a release, I say we fix it after this release like the rest of the bugs :) |
I thought that I'd fixed that issue, but anyway I agree to fix it after the next release. |
