Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix/fix: add default colors to Font versions #2115

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

lunatic-fox
Copy link
Contributor

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened

Features

Add default colors to the icons listed below. And some adjustments on other icons of the same technology.

adonisjs: [original-wordmark]
angular: [plain, plain-wordmark]
apache: [plain, plain-wordmark, line, line-wordmark]
apacheairflow: [plain, plain-wordmark]
apachespark: [plain-wordmark]
apl: [plain]
argocd: [plain, plain-wordmark]
astro: [plain, plain-wordmark]
babel: [plain]
bootstrap: [plain, plain-wordmark]
browserstack: [plain, plain-wordmark]
bun: [plain, line]
cairo: [plain, plain-wordmark]
cassandra: [plain, plain-wordmark]
centos: [plain, plain-wordmark]
clarity: [plain, plain-wordmark]
clion: [plain-wordmark]
consul: [plain-wordmark]
couchbase: [plain-wordmark]
datagrip: [plain-wordmark]
dataspell: [plain-wordmark]
djangorest: [plain, plain-wordmark, line, line-wordmark]
dreamweaver: [plain, line]
dynamodb: [plain]
ecto: [plain-wordmark]
eleventy: [plain]
elixir: [plain, plain-wordmark]
embeddedc: [plain, plain-wordmark]
ember: [plain]
figma: [plain]
fsharp: [plain]
gazebo: [plain, plain-wordmark]
gcc: [plain, line]
go: [plain, line]
godot: [plain, plain-wordmark]
goland: [plain-wordmark]
grails: [plain]
groovy: [plain]
grpc: [plain]
hadoop: [plain, plain-wordmark]
hardhat: [plain, plain-wordmark]
haskell: [plain, plain-wordmark]
homebrew: [plain, plain-wordmark, line, line-wordmark]
insomnia: [plain, plain-wordmark]
intellij: [plain-wordmark]
jamstack: [plain-wordmark]
jekyll: [plain, plain-wordmark]
jenkins: [plain, line]
jetbrains: [plain]
jira: [plain, plain-wordmark]
jiraalign: [plain, plain-wordmark]
julia: [plain, plain-wordmark]
jupyter: [plain, plain-wordmark]
kdeneon: [plain]
keras: [plain, plain-wordmark, line, line-wordmark]
knexjs: [plain-wordmark]
ktor: [plain-wordmark]
labview: [plain, plain-wordmark]
linkedin: [plain, plain-wordmark]
llvm: [plain]
materializecss: [plain]
matlab: [plain]
maven: [plain, plain-wordmark]
neo4j: [plain, plain-wordmark]
neovim: [plain, plain-wordmark, line, line-wordmark]
netlify: [plain, plain-wordmark]
ngrx: [plain]
nimble: [plain]
nomad: [plain-wordmark]
norg: [plain]
notion: [plain, line]
nuxtjs: [plain, plain-wordmark]
ocaml: [plain, plain-wordmark]
opencv: [plain, plain-wordmark]
openstack: [plain-wordmark]
perl: [plain]
phoenix: [plain-wordmark]
php: [plain]
phpstorm: [plain-wordmark]
playwright: [plain]
plotly: [plain, plain-wordmark]
pnpm: [plain, plain-wordmark]
podman: [plain, plain-wordmark]
polygon: [plain, plain-wordmark]
powershell: [plain]
pycharm: [plain, plain-wordmark]
pypi: [plain, plain-wordmark]
qodana: [plain-wordmark]
rabbitmq: [plain-wordmark]
reach: [plain]
readthedocs: [line]
realm: [plain, plain-wordmark]
renpy: [plain]
rider: [plain-wordmark]
rockylinux: [plain-wordmark]
rubymine: [plain-wordmark]
scikitlearn: [plain, line]
reactrouter: [plain, plain-wordmark]
solidjs: [plain, plain-wordmark]
spack: [plain]
sqlite: [plain, plain-wordmark]
stackoverflow: [plain, plain-wordmark, line, line-wordmark]
storybook: [plain, plain-wordmark]
supabase: [plain, plain-wordmark]
svelte: [plain, plain-wordmark]
swagger: [plain, plain-wordmark]
swift: [plain, plain-wordmark]
swiper: [original]
tailwindcss: [plain-wordmark]
tauri: [plain, plain-wordmark]
terraform: [plain, plain-wordmark]
thealgorithms: [plain, plain-wordmark]
tomcat: [line, line-wordmark]
tortoisegit: [plain, line]
trpc: [plain, plain-wordmark]
ubuntu: [plain, plain-wordmark]
unity: [plain, plain-wordmark, line, line-wordmark]
vagrant: [plain, plain-wordmark]
vala: [plain, plain-wordmark]
vault: [plain-wordmark]
vitejs: [plain]
vitess: [plain, plain-wordmark]
vitest: [plain]
vscode: [plain, plain-wordmark]
wasm: [plain-wordmark]
webstorm: [plain-wordmark]
yaml: [plain]
yarn: [line, line-wordmark]
yii: [plain, plain-wordmark]
yugabytedb: [plain, plain-wordmark]
zig: [plain-wordmark]

This PR closes #2105 - [LP] Add default color

Notes

The code to add colors can be found here: https://gist.github.com/lunatic-fox/fdb53e596701fe12cbe38030ac4e5f6b

@lunatic-fox lunatic-fox requested review from a team, ConX, weh, Snailedlt and canaleal and removed request for a team January 17, 2024 18:59
@Snailedlt
Copy link
Collaborator

@lunatic-fox I find it really hard to review this PR because the diff says the whole file changed. Do you know of any easy way to see the exact differences, or do you have any other tips for reviewing this PR?

@lunatic-fox
Copy link
Contributor Author

@lunatic-fox I find it really hard to review this PR because the diff says the whole file changed. Do you know of any easy way to see the exact differences, or do you have any other tips for reviewing this PR?

Maybe slicing it into around 10 - 20 icons per pull request, that way I think GitHub will be able to render it properly.

@Snailedlt
Copy link
Collaborator

@lunatic-fox I think the issue is that GitHub has trouble rendering single-line diffs. I've seen this issue on multiple new icon PRs before too, so I don't think it's because of the amount of svg's

@lunatic-fox
Copy link
Contributor Author

lunatic-fox commented Jan 17, 2024

@lunatic-fox I think the issue is that GitHub has trouble rendering single-line diffs. I've seen this issue on multiple new icon PRs before too, so I don't think it's because of the amount of svg's

Hmm, so in that case, maybe I can prettify the output svgs. However, we should test if the web vscode shows the diffs first.

@Snailedlt
Copy link
Collaborator

@lunatic-fox good idea. I created a codespace here: https://musical-space-invention-ppj4wj4vwj4c9rgj.github.dev/

@Snailedlt
Copy link
Collaborator

@lunatic-fox
The diff in web-vscode is better, but it's still a bit hard to see the changes imo, since some things have just been moved, but are shown as removed/added
image

@lunatic-fox
Copy link
Contributor Author

@Snailedlt
I still don't see a better option to review the code beside web vscode viewer. However, I can improve the way of previewing it by creating a comment with a list like that:

Tech name devicons:develop lunatic-fox:fx-add-default-colors
apl

@Snailedlt
Copy link
Collaborator

@lunatic-fox yeah me neither :/
Previewing isn't any problem, so no need doing that. If the icons are used as a font, and yoyu changed anything besides the fill color we also need to preview the fonts on icomoon. If you could upload screenshots from there it'll go much faster to review! :D

@lunatic-fox
Copy link
Contributor Author

This commit also modifies godot-original, jekyll-original, jekyll-original-wordmark, neo4j-original
and neo4j-original-wordmark, because their plain versions are smaller than 128px.

The icons listed below have to be off-colored since white has no contrast on itself.

  • angular-plain
  • angular-plain-wordmark
  • notion-line
  • notion-plain

image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
image
...

@lunatic-fox
Copy link
Contributor Author

Well... It seems that I can't upload any image, so here's a zip file containing the screenshots.
Screenshots.zip

Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vscode plain wordmark version has some artifacts: Screenshot_2024_0118_084615.png

Other than that everything looks great!

@lunatic-fox
Copy link
Contributor Author

Vscode plain wordmark version has some artifacts: Screenshot_2024_0118_084615.png

Other than that everything looks great!

Fixed!
image

Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅
Excellent work lunatic!

Copy link
Member

@canaleal canaleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent stuff! Great work 🚀

There's a few SVGs that are don't reach the edges of the viewbox or go beyond like the notion line svg. Thankfully, these are small problems that can be patched in.

image

@Snailedlt
Copy link
Collaborator

@canaleal I think that's just visually on icomoon. Iirc from reviewing the notion PR, the icons are sized and centered correctly, but icomoon has some sort of negative padding issue, which is why it looks like it goes outside the viewbox.
We should definitely double check tho, but as you say it's not critical and can be fixed later if it's an issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants