-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 2.9.0 #485
Merged
Release 2.9.0 #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull latest commit from upstream Develop
…re/icon/sqlalchemy
new icon: Eleventy (original, plain)
* new icon sqlserver (plain, plain-woodmark) * Update icons/sqlserver/sqlserver-plain-wordmark.svg Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com> * Update icons/sqlserver/sqlserver-plain.svg Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com> * Update devicon.json Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com> * Update devicon.json Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com> * Rename sqlserver icons to microsoftsqlserver Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com>
* new icon: kubernetes (plain, plain-wordmark) * Update icons/kubernetes/kubernetes-plain.svg Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com> * Update icons/kubernetes/kubernetes-plain-wordmark.svg Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com> Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com>
* new icon: rocksdb (plain) * Update icons/rocksdb/rocksdb-plain.svg Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com> Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com>
…mark) (#428) * new icon: googlecloud (plain, plain-wordmark, original, original-wordmark) * Update icons/googlecloud/googlecloud-plain.svg Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com> * Update icons/googlecloud/googlecloud-original-wordmark.svg Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com> * Update icons/googlecloud/googlecloud-original.svg Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com> * Fix google cloud icons * Fix googlecloud original * Remove fill redefinition from google cloud original * Fix googlecloud alignment (Test) * Fix googlecloud alignment (test) * Fix googlecloud alignment (test) Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com>
* new icon: objectivec (plain) * Update icons/objectivec/objectivec-plain.svg Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com> Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com>
Co-authored-by: Thomas Bui <43018778+Thomas-Boi@users.noreply.github.com>
* add icon Firebase (plain, plain-wordmark), Closes #204 * new icon: firebase (plain, plain-wordmark) * update icons * Add plain-wordmark to firebase fonts
* Cleanup flask icon * Improve flask icons * Update icons/flask/flask-original-wordmark.svg Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com> Co-authored-by: moghya <sawantshubham571@gmail.com> Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com>
new icon: uwsgi (original, plain)
…hemy new icon: sqlalchemy (original, original-wordmark, plain)
Fixed an error with devicon.json
…ssues (#460) * Added script to check svg fill and viewBox * Fix cucumber-plain-wordmark * Fix various fill and viewBox issues in svgs * Added check for height and width attr * Added check_svgs workflow * Fix an issue where the error is not log properly * Added on push for testing * Updated trigger so it now runs whenever PR is update * Added sleep to script to make logs nicer * Added script that create env var * Updated the github_env to accomodate ubuntu * Change format of log and allow filehandler to return Path * Updated logging messages * Updated refs for the checkout action * Make logging nicer * Updated fix messaging so it's more clear * fix icons: icons/cucumber/cucumber-plain-wordmark.svg, icons/intellij/intellij-plain-wordmark.svg, icons/jenkins/jenkins-plain.svg, icons/twitter/twitter-original.svg, icons/yunohost/yunohost-plain.svg
* Remove head_ref from checkout action * Fixed the svg errs in sqlalchemy
Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com>
Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com>
new icon: Adobe XD (plain, line)
As the result of discussion #470 update guidelines with squash merging
…guideline Add guideline about squash merging
Added working workflows that has commenting on forked repo's PR.
* Added Appwrite icon * Fixed wrong JSON input * Fixed JSON style * Fixed indent * Update devicon.json Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com> * Update devicon.json Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com> * Update devicon.json Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com> Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com>
* fix bash-plain (#451) (#453) Co-authored-by: Enis Mulić <enis.s.mulic@gmail.com> * Built new icons, icomoon.json and devicon.css Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com> Co-authored-by: Enis Mulić <enis.s.mulic@gmail.com> Co-authored-by: amacado <amacado@users.noreply.github.com>
Removed 'default fall back icon' from build_icons.yml
Thomas-Boi
approved these changes
Jan 20, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything seems good to me. Hopefully the posting comments workflows will work once we merge it into master.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we are ready for a new release with 12 fresh icons:
Icons
Features
Fix
Thanks to all contributors for this release @tylensthilaire @EnisMulic @Th1nkK1D @eldadfux @Thomas-Boi
I will build the current(#486).development
branch, merge the results into it and then change the status from draft to ready for review