Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: Adobe XD (plain, line) #81

Merged
merged 7 commits into from
Jan 9, 2021
Merged

Conversation

Th1nkK1D
Copy link
Contributor

I added .svg and .eps icon for Adobe XD using the same guideline from your Photoshop and Illustrator icon. Still, it needs to be included in the font file later on.

icons/xd/xd-line.svg Outdated Show resolved Hide resolved
@amacado amacado added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Jun 8, 2020
Copy link
Member

@amacado amacado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. Please take a look at our updated contribution guidelines and pay special attention to:

  • Modify devicon.json to include the icon (or variations)
  • Modify devicon-colors.css to include the colored version of the icon

@Thomas-Boi
Copy link
Member

Hello there,
Recently, we just introduced an automation pipeline to Devicon which will help us create the icons. Before we can merge your changes in, there are a few things that we need to do first:

  1. Merge the current devicon/develop branch into your PR branch. This contains the build script needed for us to build your icons.
  2. Read the CONTRIBUTING.md for things to do before merging and review our icon standards.
  3. Push your changes and/or branches. We will review them once this is done and merge your PR if everything goes well.

Thank you for contributing to this repo. We are sorry that we haven't accept any PR for awhile. Now that we have a build pipeline, we can merge PRs more quickly than before.

We hope to see your icons in the Devicon repo soon :)

Cheers,
Devicon Team

@Thomas-Boi Thomas-Boi added the stale For PRs that haven't had any activity for a while and old issues label Jan 6, 2021
@Thomas-Boi
Copy link
Member

Hello there,

We notice that this PR has been inactive for awhile now. It would be a waste of your time and effort if we just close this PR and throw away the SVGs in here. Thus, 1 month from now, if this PR remains inactive/stale, we will fork your repo, fix any issues, and merge your icons ourselves.

Since GitHub tracks contributions by commits, you will still be credited. We also hope that you will help us merge this PR before the deadline comes.

Cheers,
Devicon Team

@Th1nkK1D Th1nkK1D changed the base branch from master to develop January 6, 2021 09:30
@Th1nkK1D Th1nkK1D changed the title Add Adobe XD icon new icon: Adobe XD (plain, line) Jan 6, 2021
@Th1nkK1D
Copy link
Contributor Author

Th1nkK1D commented Jan 6, 2021

Sorry for letting this PR stale for a while. 🙏🏼
Please let me know if there is something still missing.

Copy link
Member

@amacado amacado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Th1nkK1D thanks for picking up this pull request. Please have a look at my suggestions :)

icons/xd/xd-line.svg Outdated Show resolved Hide resolved
icons/xd/xd-plain.svg Outdated Show resolved Hide resolved
icons/xd/xd-line.svg Outdated Show resolved Hide resolved
icons/xd/xd-plain.svg Outdated Show resolved Hide resolved
@@ -3044,6 +3044,16 @@
"color": "#494949",
"aliases": []
},
{
"name": "xd",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choosing xd as the name of the icon could be missleading. I would suggest to name it adobexd. @Thomas-Boi What do you think? (I'm thinking of aftereffects and premierepro where we have no adobe in front).

Please have a look at this discussion #459, we decided to not introduce hyphens.

Suggested change
"name": "xd",
"name": "adobexd",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At first, I choose xd becase all other Adobe products in this icon set don't have the adobe prefix to keep the consistancy. But just xd can be confused as well. So I don't have a string opinion on this 🤔

Th1nkK1D and others added 3 commits January 9, 2021 16:15
Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com>
Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com>
Copy link
Member

@Thomas-Boi Thomas-Boi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me. The xd might seems a bit vague but it seems like most people associate it with Adobe XD so this should be ok.

Also, regarding the check svg script, for some reason the comment bot stops working. However, this is an add on, not the main test being run. Therefore, all your svgs are fine.

@Thomas-Boi Thomas-Boi merged commit 340e85e into devicons:develop Jan 9, 2021
@amacado amacado mentioned this pull request Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature:icon Use this label for pull requests when a new icon is ready to be added to the collection stale For PRs that haven't had any activity for a while and old issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants