-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new icon: matlab (original, plain) #492
Conversation
Release v2.8.2
* Create eleventy-original.svg * Create eleventy-plain.svg * Update devicon.json * Update eleventy-plain.svg * Update eleventy-original.svg * new icon: sqlalchemy (plain, original, original-workmark) * Add font aliase for sqlalchemy * new icon: microsoftsqlserver (plain, plain-wordmark) (#427) * new icon sqlserver (plain, plain-woodmark) * Update icons/sqlserver/sqlserver-plain-wordmark.svg Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com> * Update icons/sqlserver/sqlserver-plain.svg Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com> * Update devicon.json Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com> * Update devicon.json Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com> * Rename sqlserver icons to microsoftsqlserver Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com> * new icon: kubernetes (plain, plain-wordmark) (#424) * new icon: kubernetes (plain, plain-wordmark) * Update icons/kubernetes/kubernetes-plain.svg Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com> * Update icons/kubernetes/kubernetes-plain-wordmark.svg Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com> Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com> * new icon: rocksdb (plain) (#423) * new icon: rocksdb (plain) * Update icons/rocksdb/rocksdb-plain.svg Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com> Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com> * new icon: googlecloud (original, original-wordmark, plain, plain-wordmark) (#428) * new icon: googlecloud (plain, plain-wordmark, original, original-wordmark) * Update icons/googlecloud/googlecloud-plain.svg Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com> * Update icons/googlecloud/googlecloud-original-wordmark.svg Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com> * Update icons/googlecloud/googlecloud-original.svg Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com> * Fix google cloud icons * Fix googlecloud original * Remove fill redefinition from google cloud original * Fix googlecloud alignment (Test) * Fix googlecloud alignment (test) * Fix googlecloud alignment (test) Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com> * new icon: objectivec (plain) (#425) * new icon: objectivec (plain) * Update icons/objectivec/objectivec-plain.svg Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com> Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com> * new icon uwsgi (original, plain) * Cleanup uwsgi icons * Update devicon.json Co-authored-by: Thomas Bui <43018778+Thomas-Boi@users.noreply.github.com> * Add adobe XD line icon * Add xd-plain and eps file * Clean up xd svg file * Update devicon.json * new icon: firebase (plain, plain-wordmark) (#461) * add icon Firebase (plain, plain-wordmark), Closes #204 * new icon: firebase (plain, plain-wordmark) * update icons * Add plain-wordmark to firebase fonts * new icon: flask (original, original-wordmark) (#463) * Cleanup flask icon * Improve flask icons * Update icons/flask/flask-original-wordmark.svg Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com> Co-authored-by: moghya <sawantshubham571@gmail.com> Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com> * Update devicon.json * Fixed an error with devicon.json * Added check script for the icons and fix icons with fill or viewBox issues (#460) * Added script to check svg fill and viewBox * Fix cucumber-plain-wordmark * Fix various fill and viewBox issues in svgs * Added check for height and width attr * Added check_svgs workflow * Fix an issue where the error is not log properly * Added on push for testing * Updated trigger so it now runs whenever PR is update * Added sleep to script to make logs nicer * Added script that create env var * Updated the github_env to accomodate ubuntu * Change format of log and allow filehandler to return Path * Updated logging messages * Updated refs for the checkout action * Make logging nicer * Updated fix messaging so it's more clear * fix icons: icons/cucumber/cucumber-plain-wordmark.svg, icons/intellij/intellij-plain-wordmark.svg, icons/jenkins/jenkins-plain.svg, icons/twitter/twitter-original.svg, icons/yunohost/yunohost-plain.svg * Fix the ref issue of the checkout action and sqlalchemy (#472) * Remove head_ref from checkout action * Fixed the svg errs in sqlalchemy * Create a monthly script that checks all svgs * Python now print traceback * Updated file names in check_svgs_on_pr * Remove deprecated and unused svg syntax Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com> * Remove deprecated and unused svg syntax Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com> * Update svg fill, remove unused class * Change comment action to a new action * Add guideline about squash merging As the result of discussion #470 update guidelines with squash merging * Redo the workflow archs so we can comment on pr * Moved check_svgs_monthly to draft * Added working workflow file * Changed to file read action * new icon: appwrite (plain, original, wordmark) (#371) * Added Appwrite icon * Fixed wrong JSON input * Fixed JSON style * Fixed indent * Update devicon.json Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com> * Update devicon.json Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com> * Update devicon.json Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com> Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com> * bot:build new icons, icomoon.json and devicon.css (#486) * fix bash-plain (#451) (#453) Co-authored-by: Enis Mulić <enis.s.mulic@gmail.com> * Built new icons, icomoon.json and devicon.css Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com> Co-authored-by: Enis Mulić <enis.s.mulic@gmail.com> Co-authored-by: amacado <amacado@users.noreply.github.com> * Removed 'default fall back icon' from build_icons.yml Co-authored-by: Tylen St Hilaire <28753109+tylensthilaire@users.noreply.github.com> Co-authored-by: Enis Mulić <enis.s.mulic@gmail.com> Co-authored-by: Thomas Bui <43018778+Thomas-Boi@users.noreply.github.com> Co-authored-by: Withee Poositasai <witheep@gmail.com> Co-authored-by: moghya <sawantshubham571@gmail.com> Co-authored-by: Thomas Bui <thomasbui198@gmail.com> Co-authored-by: Eldad A. Fux <eldad.fux@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: amacado <amacado@users.noreply.github.com>
Hi! I'm Devicons' SVG-Checker Bot and it seems we have some issues with your SVGs. Here is what went wrong:
For more reference on why these are errors, check out our CONTRIBUTING guide Please address these issues. When you update this PR, I will check your SVGs again. Thanks for your help, PS. One day, I will be smart enough to fix these errors for you 😣. Until then, I can only point them out. |
Hi! Everything looks great. Good job! Have a nice day, |
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here are the zoomed-in screenshots of the added icons: Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice. The maintainers will now take a look at it and decide whether to merge your PR. Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo. Cheers, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @Panquesito7 and thanks for adding matlab! :) Sadly the icon you provided does not fulfill our requirements.
As you can see in the screenshots posted by our bot the font version looks does not look like you might expect it. This is way we have introduct a plain
version which simplifies a icon so it looks good in one-colored. Feel free to commit a plain version of matlab :) Since our guidelines require a valid font version of a icon I'm unable to approve your pull request :(
Side note: When I google the Matlab logo it looks more like a green-blue color (https://de.wikipedia.org/wiki/Matlab#/media/Datei:Matlab_Logo.png) than a solid blue like in your contribution...
Oh sorry, I'm still kinda new to this thing. I wasn't sure if to keep the EDIT: I will try to make the |
About the color: Is this icon OK? https://icons8.com/icons/set/matlab |
Oops, the icon has a white background, working on fixing it. |
Hi! I'm Devicons' SVG-Checker Bot and it seems we have some issues with your SVGs. Here is what went wrong:
For more reference on why these are errors, check out our CONTRIBUTING guide Please address these issues. When you update this PR, I will check your SVGs again. Thanks for your help, PS. One day, I will be smart enough to fix these errors for you 😣. Until then, I can only point them out. |
1 similar comment
Hi! I'm Devicons' SVG-Checker Bot and it seems we have some issues with your SVGs. Here is what went wrong:
For more reference on why these are errors, check out our CONTRIBUTING guide Please address these issues. When you update this PR, I will check your SVGs again. Thanks for your help, PS. One day, I will be smart enough to fix these errors for you 😣. Until then, I can only point them out. |
Hi! I'm Devicons' SVG-Checker Bot and it seems we have some issues with your SVGs. Here is what went wrong:
For more reference on why these are errors, check out our CONTRIBUTING guide Please address these issues. When you update this PR, I will check your SVGs again. Thanks for your help, PS. One day, I will be smart enough to fix these errors for you 😣. Until then, I can only point them out. |
Hi! I'm Devicons' SVG-Checker Bot and it seems we have some issues with your SVGs. Here is what went wrong:
For more reference on why these are errors, check out our CONTRIBUTING guide Please address these issues. When you update this PR, I will check your SVGs again. Thanks for your help, PS. One day, I will be smart enough to fix these errors for you 😣. Until then, I can only point them out. |
If you go to their official website, it is blue, not green-blue. |
Hi! I'm Devicons' SVG-Checker Bot and it seems we have some issues with your SVGs. Here is what went wrong:
For more reference on why these are errors, check out our CONTRIBUTING guide Please address these issues. When you update this PR, I will check your SVGs again. Thanks for your help, PS. One day, I will be smart enough to fix these errors for you 😣. Until then, I can only point them out. |
Edited the first post. |
Hi! I'm Devicons' SVG-Checker Bot and it seems we have some issues with your SVGs. Here is what went wrong:
For more reference on why these are errors, check out our CONTRIBUTING guide Please address these issues. When you update this PR, I will check your SVGs again. Thanks for your help, PS. One day, I will be smart enough to fix these errors for you 😣. Until then, I can only point them out. |
Hi! I'm Devicons' SVG-Checker Bot and it seems we have some issues with your SVGs. Here is what went wrong:
For more reference on why these are errors, check out our CONTRIBUTING guide Please address these issues. When you update this PR, I will check your SVGs again. Thanks for your help, PS. One day, I will be smart enough to fix these errors for you 😣. Until then, I can only point them out. |
@amacado all issues have been fixed. Please see my previous comment, and please review my PR. Thank you. 🙂 |
Hi! I'm Devicons' SVG-Checker Bot and it seems we have some issues with your SVGs. Here is what went wrong:
For more reference on why these are errors, check out our CONTRIBUTING guide Please address these issues. When you update this PR, I will check your SVGs again. Thanks for your help, PS. One day, I will be smart enough to fix these errors for you 😣. Until then, I can only point them out. |
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here are the zoomed-in screenshots of the added icons: Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice. The maintainers will now take a look at it and decide whether to merge your PR. Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo. Cheers, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no idea why the bot is reporting a error with bash-plain.svg
and devicon.svg
.. Strange behaviour.. I checked the icon and it looks good! Thanks @Panquesito7. I would only suggest to change to color (see my review suggestion)
Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com>
Hi! I'm Devicons' SVG-Checker Bot and it seems we have some issues with your SVGs. Here is what went wrong:
For more reference on why these are errors, check out our CONTRIBUTING guide Please address these issues. When you update this PR, I will check your SVGs again. Thanks for your help, PS. One day, I will be smart enough to fix these errors for you 😣. Until then, I can only point them out. |
Done! Color changed. |
Hi! I'm Devicons' SVG-Checker Bot and it seems we have some issues with your SVGs. Here is what went wrong:
For more reference on why these are errors, check out our CONTRIBUTING guide Please address these issues. When you update this PR, I will check your SVGs again. Thanks for your help, PS. One day, I will be smart enough to fix these errors for you 😣. Until then, I can only point them out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm approving this now! It was a very confusing pull request due to the fact it was opened against the master branch on not develop branch.. Next time please open the pull request to develop
branch (and start by checking out the develop
branch) ;-)
Anyway: icon looking fine now! Thanks for adding matlab to this project! :) It will be included in the next release!
So sorry for this; it was my first time contributing, and I didn't do things well. Next time, I'll do everything as per the contributing guidelines. Thank you! 😄 |
I added the icon for the MATLAB programming language.
As I didn't find out any original images in
.svg
, I had to take it from the first commit in thevscode-icons
repository. I resized it using theresize-image
tool. 🙂I only need help setting up the color in
devicon.json
. I don't know how does it work exactly.This is how it looks:
If I missed up anything please let me know. Thank you.