Disable rogue command echo #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also removes redundant condition.
Better for code search.
|
Actually, you effectively have your whitespace preferences in .editorconfig, so happy to submit a pull request using that. |
|
Good catch and nice improvement for consistency and readability! Happy to take a separate PR with the .editorconfig preference applied |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered a rogue command echo while debugging a build this week.
I also took the opportunity to reorder command conditions, both to be consistent and it happens to be better for code search as it always shows the command when searching text for
<Exec, for example.Finally, I see the whitespace is very inconsistent with a mix of spaces and tabs, and a mix of indentations from 2 to 4 spaces. I was tempted to clean this up too - let me know if you would take a pull request for that, and if so what are your preferences either way. 😛