Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean code #352

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Clean code #352

merged 1 commit into from
Jun 25, 2024

Conversation

gitfool
Copy link
Contributor

@gitfool gitfool commented Jun 17, 2024

Following up from #342 (comment), I tweaked the code to be clean and consistent as follows:

  • whitespace tabs to spaces
  • remove redundant whitespace
  • increase line lengths and reduce hard-coded wrap
  • normalize xml attributes
    • use double quotes (")
    • expression case from And, Or to and, or
    • move Condition attributes to end
    • reorder all other attributes for consistency (*)

(*) this flushed out some minor differences between some Exec tasks that I also fixed.

@gitfool
Copy link
Contributor Author

gitfool commented Jun 17, 2024

@kzu PTAL. If you're happy with this PR then it really needs to be merged before I would want to submit any other PRs due to the number of lines touched. 😊

@kzu
Copy link
Member

kzu commented Jun 25, 2024

Uff, massive! Not gonna nick-pick, as a whole, it looks WAY better than before. Masive thanks, and looking forward what's next! 🎉

@kzu kzu merged commit 4d79857 into devlooped:main Jun 25, 2024
5 checks passed
@gitfool gitfool deleted the clean-code branch June 25, 2024 08:03
@devlooped devlooped locked and limited conversation to collaborators Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants