Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add backwards compatibility for breaking change from --protocol to --scheme #25

Closed
kzu opened this issue May 1, 2024 · 0 comments · Fixed by #26
Closed

Add backwards compatibility for breaking change from --protocol to --scheme #25

kzu opened this issue May 1, 2024 · 0 comments · Fixed by #26
Labels
bug Something isn't working

Comments

@kzu
Copy link
Member

kzu commented May 1, 2024

Describe the Bug

To make the option consistent across all three commands, we renamed --protocol to --scheme so we could always use the shorthand -s regardless of whether there was a -p|--password option too.

This caused older invocations to break since the protocol would be null/empty and thus a matching provider was not found (i.e. for github).

Version Info

Appeared in v2.4.1

@kzu kzu added the bug Something isn't working label May 1, 2024
kzu added a commit that referenced this issue May 1, 2024
Which is now --scheme.

To make the option consistent across all three commands, we renamed --protocol to --scheme so we could always use the shorthand -s regardless of whether there was a -p|--password option too.

This caused older invocations to break since the protocol would be null/empty and thus a matching provider was not found (i.e. for github).

Fixes #25
kzu added a commit that referenced this issue May 1, 2024
Which is now --scheme.

To make the option consistent across all three commands, we renamed --protocol to --scheme so we could always use the shorthand -s regardless of whether there was a -p|--password option too.

This caused older invocations to break since the protocol would be null/empty and thus a matching provider was not found (i.e. for github).

Fixes #25
@kzu kzu closed this as completed in #26 May 1, 2024
kzu added a commit that referenced this issue May 1, 2024
Which is now --scheme.

To make the option consistent across all three commands, we renamed --protocol to --scheme so we could always use the shorthand -s regardless of whether there was a -p|--password option too.

This caused older invocations to break since the protocol would be null/empty and thus a matching provider was not found (i.e. for github).

Fixes #25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant