Fix NullReferenceException when using write-only indexer with VerifySet
#1037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The expression splitting logic is a little hacky when it comes to assignments to property or indexer setters: first, a split operation is performed as if we were looking at a property or indexer *getter*; the `InvocationShape` receives the correct method, but is one argument short. Once that first `InvocationShape` has been built, we can create a second, patched and fully correct version that includes the assign- ment (RHS) argument. This commit relaxes validation rules for the first `InvocationShape` (i.e. the one with the potential argument count mismatch).
stakx
force-pushed
the
write-only-indexer-assignment
branch
from
4209825
to
f32a129
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1036.