Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NullReferenceException when using write-only indexer with VerifySet #1037

Merged
merged 3 commits into from
Jun 30, 2020
Merged

Fix NullReferenceException when using write-only indexer with VerifySet #1037

merged 3 commits into from
Jun 30, 2020

Commits on Jun 30, 2020

  1. VerifySet fails for write-only indexers

    @stakx
    stakx committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    0176fa0 View commit details
    Browse the repository at this point in the history

  2. Prevent argument count mismatch 

    The expression splitting logic is a little hacky when it comes to
assignments to property or indexer setters: first, a split operation
is performed as if we were looking at a property or indexer *getter*;
the `InvocationShape` receives the correct method, but is one argument
short. Once that first `InvocationShape` has been built, we can create
a second, patched and fully correct version that includes the assign-
ment (RHS) argument.

This commit relaxes validation rules for the first `InvocationShape`
(i.e. the one with the potential argument count mismatch).
    @stakx
    stakx committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    9351aba View commit details
    Browse the repository at this point in the history

  3. Update the changelog

    @stakx
    stakx committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    f32a129 View commit details
    Browse the repository at this point in the history