Fix build errors after merging master to netcore #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, `object.Equals(object obj)` and `object.GetHashCode()`.
…s. Also fixed a couple of white space errors.
Allow for class mocks and interface mocks to mock System.Object methods
…ne of them were set up. Fixes devlooped#273.
`System.Object` methods should always work.
…ct methods in the interceptor context. Fixes devlooped#273 (again :-)) (devlooped#280)
…ype implements multiple interfaces (devlooped#288)
…ew VB test assembly, hopefully in a way people will be happy with (devlooped#291)
…ult rather than create a TaskCompletionSource
T4-generated overloads for ReturnsAsync(Func<T1, T2, ... TResult> value)
adds ReturnAsync extention method that accepts a Func<TResult>
* ReturnsAsync() lazy evaluation issue fix devlooped#303
* Fixes devlooped#278. Only fixes some of the issue though. Also adds new VB test assembly, hopefully in a way people will be happy with * Another fix for issue devlooped#278 that no longer causes issue devlooped#295. There is still problematic code in the Interceptor for comparing the arguments of calls, but for now it no longer causes a problem with propeties with arguments as the expression string builder now reports the arguments for property reads. I've added a comment explaining the flaws (as I see them) in the Interceptor code in the hope that it will help when someone next as a problem, or at least stops them missing the same thing as I did earlier.
# Conflicts: # Moq.sln # Source/Extensions.cs # Source/InterceptorStrategies.cs # Source/Mock.cs # Source/Proxy/CastleProxyFactory.cs # UnitTests/Regressions/IssueReportsFixture.cs
It's unfortunate that conditional compilation directives cannnot contain just part of a Xml Doc comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.