Introduce new abstract base class Setup
#671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`MethodCall` represents a setup that is programmable through Moq's `Setup` API. There are, however, certain kinds of "internal" setups that are not programmable and have much simpler logic. The intent behind this refactoring is to create a base class for all setups that has a much smaller memory footprint and contains much less logic. Internal, non-programmable setup types can then eventually be derived from that new `Setup` class.
It appears as if all setup types would eventually implement this property in exactly the same way, so we can just as well do it once in the base class.
This is needed if we want to convert `SequenceMethodCall` away from `MethodCall`. `SetupWithOutParameterSupport` captures Moq's slightly counter-intuitive semantics whereby `out` arguments are read at setup time to find out what they should be set to during an invocation. This happens for both regular and sequence setups, but isn't built into the `Setup` base class, so we need a new in-between class for sequence setups to derive from--this is it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MethodCallrepresents a setup that is programmable through Moq'sSetupAPI. There are, however, certain kinds of "internal" setups that are not programmable and have much simpler logic.The intent behind this refactoring is to create a base class for all setups that has a much smaller memory footprint and contains much less logic. Internal, non-programmable setup types can then eventually be derived from that new
Setupclass.This PR includes the conversion of
PropertyGetterMethodCall,PropertySetterMethodCall, andSequenceMethodCallto the new & lighter-weightSetupbase class, including renames to more precise & more consistent names:PropertyGetterMethodCall→AutoImplementedPropertyGetterSetupPropertySetterMethodCall→AutoImplementedPropertySetterSetupSequenceMethodCall→SequenceSetupThis PR does not change
MethodCallitself much—that is left to a separate, future refactoring.