Fix VerifyAll + VerifyNoOtherCalls for sequence setups
#672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a regression caused by the introduction of the new `Setup` base class. `MethodCall.Execute` contains logic that marks invocations as matched by a setup, which is required for `VerifyNoOtherCalls` to work well together with `Verify[All]`. This logic will have to be extracted from `MethodCall`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous refactoring (#671) has broken the combination of using
VerifyAllfollowed byVerifyNoOtherCallsfor sequence setups. This PR adds a regression test for such a scenario, and fixes it.