Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#636 Helm Integration #714

Merged
merged 14 commits into from
Mar 24, 2022
Merged

#636 Helm Integration #714

merged 14 commits into from
Mar 24, 2022

Conversation

CREITZ25
Copy link
Member

@CREITZ25 CREITZ25 commented Mar 7, 2022

#636 Helm Integration

@CREITZ25
#636 Helm Integration
3c041d2 
#636 Helm Integration
hohwille
hohwille requested changes Mar 7, 2022
View reviewed changes
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CREITZ25 analog to #709
Also I am missing the change to documentation/LICENSE.asciidoc

scripts/src/main/resources/scripts/command/helm Outdated Show resolved Hide resolved
@github-actions github-actions bot added bash related to bash shell or scripts commandlet related to commandlets (scripts/command/*) documentation related to documentation (AsciiDoc) scripts related to shell scripts (bash and CMD) labels Mar 7, 2022
@hohwille hohwille linked an issue Mar 10, 2022 that may be closed by this pull request
The installation of helm aborts due to an existing installation of helm from rancher desktop installation. #715
Closed
@CREITZ25
#636 Helm integration
57567ba 
#636 Helm integration replace commandlet
hohwille
hohwille requested changes Mar 22, 2022
View reviewed changes
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setup now working 👍
only a typo left and the version check output should still be present

scripts/src/main/resources/scripts/command/helm Outdated Show resolved Hide resolved
scripts/src/main/resources/scripts/command/helm Show resolved Hide resolved
@CREITZ25
#714 Helm Integration
84cd41c 
#714 Helm Integration - add version output
hohwille
hohwille approved these changes Mar 22, 2022
View reviewed changes
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent, perfect now.

@hohwille
Copy link
Member

With my latest commit the build should go green and I can merge.

@hohwille
Copy link
Member

hohwille commented Mar 24, 2022 •
edited
Loading

@CREITZ25
license/cla Expected — Waiting for status to be reported

Did you forgot to sign the CLA? This is required once for every developer in devonfw.
https://github.com/devonfw/.github/blob/master/CONTRIBUTING.asciidoc#definition-of-done
https://cla-assistant.io/devonfw/architectures

Update: Was a temporary issue. Check went to green so it seems you had already done this some time ago. Simply ignore this comment. Thanks.

@hohwille hohwille merged commit 7e6edb7 into master Mar 24, 2022
@hohwille hohwille added this to the release:2021.12.006 milestone Mar 24, 2022
@hohwille hohwille linked an issue Mar 24, 2022 that may be closed by this pull request
Helm integration #636
Closed
8 tasks
@CREITZ25 CREITZ25 deleted the feature/helm branch June 9, 2022 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hohwille hohwille hohwille approved these changes

Assignees
No one assigned
Labels
bash related to bash shell or scripts commandlet related to commandlets (scripts/command/*) documentation related to documentation (AsciiDoc) scripts related to shell scripts (bash and CMD)
Projects
None yet
Milestone
release:2022.04.001
2 participants
@CREITZ25 @hohwille