Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ZRH-2025] Change logo of sponsor cloudbees #14837

Closed
wants to merge 3 commits into from
Closed

[ZRH-2025] Change logo of sponsor cloudbees #14837

wants to merge 3 commits into from

Conversation

romanoroth
Copy link
Contributor

@romanoroth romanoroth commented Jan 28, 2025 •
edited
Loading

  • Changed the logo of cloudbees
  • Changed the logo of infiniroot (this has been nely introduced and is only used by our event)

@romanoroth romanoroth requested a review from a team as a code owner January 28, 2025 21:23
@netlify Netlify
Copy link

netlify bot commented Jan 28, 2025 •
edited
Loading

✅ Deploy Preview for devopsdays-web ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit c8441ef
🔍 Latest deploy log https://app.netlify.com/sites/devopsdays-web/deploys/67994d58641de00009a95e81
😎 Deploy Preview https://deploy-preview-14837--devopsdays-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

toshywoshy
toshywoshy requested changes Jan 28, 2025
View reviewed changes
data/events/2016/chicago/main.yml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To change 1 line here, you're changing actually too much, there is no need for any of these changes

data/events/2025/zurich/main.yml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no actual change to this file, why are we changing EOL or EOF spacing

@toshywoshy
Copy link
Contributor

In general it is better to make these changes in seperate PR's.
As you're touching a lot of files. my major problem here is that there are block changes that actually do not contain actual changes, so why are you making this cosmetic changes for no good reason.
Did your editor do some fancy changes?

@romanoroth romanoroth closed this Jan 28, 2025
@romanoroth
Copy link
Contributor Author

Oh shit it realy looks like my VS Code went cracy. Sorry for that.
Here are the two new Pull Requests:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toshywoshy toshywoshy toshywoshy requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@romanoroth @toshywoshy