Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ZRH-2025] replaced logo of cloudbees with new one #14839

Closed

Conversation

romanoroth
Copy link
Contributor

@romanoroth romanoroth commented Jan 28, 2025

  • Replaced Logo of Cloudbees

If got this warning while I was doing the git add .

warning: in the working copy of 'data/events/2022/denver/main.yml', LF will be replaced by CRLF the next time Git touches it
warning: in the working copy of 'data/sponsors/cloudbees-before-20250128.yml', LF will be replaced by CRLF the next time Git touches it

@romanoroth romanoroth requested a review from a team as a code owner January 28, 2025 22:28
Copy link

netlify bot commented Jan 28, 2025

Deploy Preview for devopsdays-web ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 431e914
🔍 Latest deploy log https://app.netlify.com/sites/devopsdays-web/deploys/67a67d420b7d170008767461
😎 Deploy Preview https://deploy-preview-14839--devopsdays-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@toshywoshy toshywoshy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Their is a file that gets changed for no reason
Are you running the script or using an editor?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did the script do this, or did you open this with an editor?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Git did that:

warning: in the working copy of 'data/events/2022/denver/main.yml', LF will be replaced by CRLF the next time Git touches it
warning: in the working copy of 'data/sponsors/cloudbees-before-20250128.yml', LF will be replaced by CRLF the next time Git touches it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My VSCode automatically removes whitespace with yml so I just saved and it removed a white space and worked on a local build with no errors ¯_(ツ)_/¯) so pushed my change up and let's see if that works?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you requested the change @toshywoshy I'll let you clear it and then merge

@toshywoshy
Copy link
Contributor

Sorry to bother youi, but there is a problem at some level here.

@romanoroth
Copy link
Contributor Author

romanoroth commented Jan 29, 2025

Sorry to bother youi, but there is a problem at some level here.

@toshywoshy : Tried to fix it. But it seems it does not work. I have no clue how to fix this porblem.

@romanoroth
Copy link
Contributor Author

@toshywoshy: Ping?

@phrawzty
Copy link
Collaborator

phrawzty commented Feb 1, 2025

@romanoroth I don't know what the deal is with the changes to Denver's yaml, but the way forward here is to not include that file in your PR.

Two possible options: you could do the git reset / amend / force push dance to this PR, or close this and open a new PR without data/events/2022/denver/main.yml in it.

My VSCode automatically removes whitespace with yml so I just saved and it removed a white space and worked on a local build with no errors ¯\_(ツ)_/¯)
@jerdog
Copy link
Contributor

jerdog commented Feb 1, 2025

@toshywoshy / @phrawzty / @romanoroth - My VSCode automatically removes whitespace with yml so I just saved and it removed a white space and worked on a local build with no errors ¯_(ツ)_/¯) so pushed my change up and let's see if that works?

@romanoroth romanoroth closed this Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants