-
Notifications
You must be signed in to change notification settings - Fork 670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ZRH-2025] replaced logo of cloudbees with new one #14839
[ZRH-2025] replaced logo of cloudbees with new one #14839
Conversation
✅ Deploy Preview for devopsdays-web ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Their is a file that gets changed for no reason
Are you running the script or using an editor?
data/events/2022/denver/main.yml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did the script do this, or did you open this with an editor?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Git did that:
warning: in the working copy of 'data/events/2022/denver/main.yml', LF will be replaced by CRLF the next time Git touches it
warning: in the working copy of 'data/sponsors/cloudbees-before-20250128.yml', LF will be replaced by CRLF the next time Git touches it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My VSCode automatically removes whitespace with yml so I just saved and it removed a white space and worked on a local build with no errors ¯_(ツ)_/¯) so pushed my change up and let's see if that works?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As you requested the change @toshywoshy I'll let you clear it and then merge
Sorry to bother youi, but there is a problem at some level here. |
@toshywoshy : Tried to fix it. But it seems it does not work. I have no clue how to fix this porblem. |
@toshywoshy: Ping? |
@romanoroth I don't know what the deal is with the changes to Denver's yaml, but the way forward here is to not include that file in your PR. Two possible options: you could do the git reset / amend / force push dance to this PR, or close this and open a new PR without |
My VSCode automatically removes whitespace with yml so I just saved and it removed a white space and worked on a local build with no errors ¯\_(ツ)_/¯)
@toshywoshy / @phrawzty / @romanoroth - My VSCode automatically removes whitespace with yml so I just saved and it removed a white space and worked on a local build with no errors ¯_(ツ)_/¯) so pushed my change up and let's see if that works? |
If got this warning while I was doing the git add .
warning: in the working copy of 'data/events/2022/denver/main.yml', LF will be replaced by CRLF the next time Git touches it
warning: in the working copy of 'data/sponsors/cloudbees-before-20250128.yml', LF will be replaced by CRLF the next time Git touches it