Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: all downloaders #1166

Merged
merged 5 commits into from
Oct 11, 2022
Merged

Conversation

aFlyBird0
Copy link
Member

@aFlyBird0 aFlyBird0 commented Oct 11, 2022

Pre-Checklist

Note: please complete ALL items in the following checklist.

  • I have read through the CONTRIBUTING.md documentation.
  • My code has the necessary comments and documentation (if needed).
  • I have added relevant tests

Description

  1. 🍀 Proposal: Refactor downloaders #1165
  2. refactor readUserInput

Related Issues

close #1156

New Behavior (screenshots if needed)

Previous Step

image

Plugins Download

D79585AE-49AA-41FD-B6F6-44FFAFF38868

1D41BA3B-8E88-4079-9786-2E8377966BAC

A191ADB2-D75B-4C8D-97B3-0F97ED62BA9D

dtm Upgrade

AE705438-C515-4FF9-BD8E-08B25512DD37

Bugfix

There is a small bug in the previous screenshots:

image

It has been fixed in the last commit:

image

image

Signed-off-by: Bird <aflybird0@gmail.com>
Signed-off-by: Bird <aflybird0@gmail.com>
Signed-off-by: Bird <aflybird0@gmail.com>
@aFlyBird0 aFlyBird0 requested a review from a team as a code owner October 11, 2022 07:28
Signed-off-by: Bird <aflybird0@gmail.com>
@aFlyBird0 aFlyBird0 force-pushed the refactor-downloader branch from a57df4f to d11c65c Compare October 11, 2022 08:19
Signed-off-by: Bird <aflybird0@gmail.com>
Copy link
Member

@iyear iyear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@steinliber steinliber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steinliber steinliber merged commit 06eca74 into devstream-io:main Oct 11, 2022
@aFlyBird0 aFlyBird0 deleted the refactor-downloader branch November 25, 2022 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants