Skip to content

Commit

Permalink
build: fix running e2e locally with staging build env (#302)
Browse files Browse the repository at this point in the history
# Motivation

Fix e2e error `[WebServer] Error: Not found:
/components/workers/analytics.worker.js` by introducing a staging mode
that can be use to build and run the test in order to avoid loading the
analytics.

# Changes

- add mode `stagin`
- build test with staging instead of build
- don't load anyltics on staging
  • Loading branch information
peterpeterparker authored Oct 4, 2023
1 parent 819f08a commit fe753a8
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 2 deletions.
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
"scripts": {
"dev": "npm run i18n && vite dev",
"build": "npm run i18n && vite build && npm run copy:workers",
"staging": "npm run i18n && vite build --mode staging && npm run copy:workers",
"package": "svelte-kit sync && svelte-package",
"preview": "vite preview",
"check": "svelte-kit sync && svelte-check --tsconfig ./tsconfig.json",
Expand Down
2 changes: 1 addition & 1 deletion playwright.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { devices } from "@playwright/test";

const config: PlaywrightTestConfig = {
webServer: {
command: "npm run build && npm run preview",
command: "npm run staging && npm run preview",
port: 4173,
},
testDir: "e2e",
Expand Down
3 changes: 2 additions & 1 deletion src/docs/services/analytics.services.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,9 @@ import { initOrbiter } from "@junobuild/analytics";

export const initAnalytics = async () => {
const DEV = import.meta.env.DEV;
const STAGING = import.meta.env.MODE === "staging";

if (DEV) {
if (DEV || STAGING) {
return;
}

Expand Down

0 comments on commit fe753a8

Please sign in to comment.