Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: fix running e2e locally with staging build env #302

Merged
merged 1 commit into from
Oct 4, 2023
Merged

build: fix running e2e locally with staging build env #302

merged 1 commit into from
Oct 4, 2023

Conversation

peterpeterparker
Copy link
Member

@peterpeterparker peterpeterparker commented Oct 4, 2023 •
edited
Loading

Motivation

Fix e2e error [WebServer] Error: Not found: /components/workers/analytics.worker.js by introducing a staging mode that can be use to build and run the test in order to avoid loading the analytics.

Changes

  • add mode stagin
  • build test with staging instead of build
  • don't load anyltics on staging

mstrasinskis
mstrasinskis approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@mstrasinskis mstrasinskis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@peterpeterparker peterpeterparker merged commit fe753a8 into main Oct 4, 2023
6 checks passed
@peterpeterparker peterpeterparker deleted the build/fix-e2e branch October 4, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mstrasinskis mstrasinskis mstrasinskis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterpeterparker @mstrasinskis