Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix running e2e locally with staging build env #302

Merged
merged 1 commit into from
Oct 4, 2023
Merged

build: fix running e2e locally with staging build env #302

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
"scripts": {
"dev": "npm run i18n && vite dev",
"build": "npm run i18n && vite build && npm run copy:workers",
"staging": "npm run i18n && vite build --mode staging && npm run copy:workers",
"package": "svelte-kit sync && svelte-package",
"preview": "vite preview",
"check": "svelte-kit sync && svelte-check --tsconfig ./tsconfig.json",
Expand Down
2 changes: 1 addition & 1 deletion playwright.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { devices } from "@playwright/test";

const config: PlaywrightTestConfig = {
webServer: {
command: "npm run build && npm run preview",
command: "npm run staging && npm run preview",
port: 4173,
},
testDir: "e2e",
Expand Down
3 changes: 2 additions & 1 deletion src/docs/services/analytics.services.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,9 @@ import { initOrbiter } from "@junobuild/analytics";

export const initAnalytics = async () => {
const DEV = import.meta.env.DEV;
const STAGING = import.meta.env.MODE === "staging";

if (DEV) {
if (DEV || STAGING) {
return;
}

Expand Down