Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [NODE-1355] Upgrade build container to 24.04 #1946

Merged
merged 22 commits into from
Nov 26, 2024
Merged

feat: [NODE-1355] Upgrade build container to 24.04 #1946

merged 22 commits into from
Nov 26, 2024

Conversation

Bownairo
Copy link
Member

@Bownairo Bownairo commented Oct 9, 2024

No description provided.

@github-actions github-actions bot added the feat label Oct 9, 2024
Updating container image to sha256:7027729912789141064925ecc52d1bc3a4…
e9f6529 
…e8b23c204a904f33a64206df1b7c68

Image tag: a5eeb65a5703037d01fe33a863740cc546aaa72e66e8472032ea70c69304c492
@Bownairo Bownairo marked this pull request as ready for review October 10, 2024 04:31
@Bownairo Bownairo requested review from a team as code owners October 10, 2024 04:31
basvandijk
basvandijk previously approved these changes Oct 10, 2024
View reviewed changes
Copy link
Collaborator

@basvandijk basvandijk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to be upgrading to the latest Ubuntu!

ci/container/container-run.sh Show resolved Hide resolved
marko-k0
marko-k0 reviewed Oct 10, 2024
View reviewed changes
ci/container/Dockerfile Outdated Show resolved Hide resolved
tmshlvck
tmshlvck previously approved these changes Oct 10, 2024
View reviewed changes
@basvandijk basvandijk mentioned this pull request Oct 10, 2024
Merged
nmattia
nmattia reviewed Oct 10, 2024
View reviewed changes
.github/workflows-source/ci-main.yml Show resolved Hide resolved
WORKSPACE.bazel Outdated Show resolved Hide resolved
ci/container/Dockerfile Show resolved Hide resolved
ci/container/Dockerfile Outdated Show resolved Hide resolved
ci/container/Dockerfile Show resolved Hide resolved
rs/tests/BUILD.bazel Show resolved Hide resolved
NikolasHaimerl
NikolasHaimerl previously approved these changes Oct 15, 2024
View reviewed changes
@Bownairo Bownairo added the CI_ALL_BAZEL_TARGETS Runs all bazel targets and uploads them to S3 label Oct 17, 2024
nmattia
nmattia previously approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@nmattia nmattia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!!

@Bownairo
Copy link
Member Author

We've seen good results testing with the 6.11 kernel on 24.04, and will no longer keep the 20.04 rollback path around.

With this out of the way, we can move forward with upgrading the build container to 24.04.

Updating container image to sha256:6a6b2a4583db6a23f2a3a84b1051322a0f…
bdf64ef 
…975a40aa6519442f3def9810643189

Image tag: b3ce871e1c772785b1a78d88cd7a50f0ae23cc7d4791603b30dba453c2480426
@github-actions GitHub Actions
Copy link
Contributor

Run URL: https://github.com/dfinity/ic/actions/runs/11943479550

New container image: sha256:6a6b2a4583db6a23f2a3a84b1051322a0f975a40aa6519442f3def9810643189
New container tag: b3ce871e1c772785b1a78d88cd7a50f0ae23cc7d4791603b30dba453c2480426

@Bownairo Bownairo requested a review from nmattia November 21, 2024 22:07
@Bownairo Bownairo requested a review from marko-k0 November 25, 2024 19:32
joeodfinity
joeodfinity approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@joeodfinity joeodfinity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The testnet/ tree stuff looks fine.

@Bownairo Bownairo added this pull request to the merge queue Nov 26, 2024
Merged via the queue into master with commit 260f1cc Nov 26, 2024
54 checks passed
@Bownairo Bownairo deleted the eero/upgrade-2 branch November 26, 2024 19:25
Bownairo added a commit that referenced this pull request Dec 3, 2024
@Bownairo
Revert "feat: [NODE-1355] Upgrade build container to 24.04 (#1946)"
22e24a6 
This reverts commit 260f1cc excluding
container tags.
@Bownairo Bownairo mentioned this pull request Dec 3, 2024
Merged
nmattia added a commit that referenced this pull request Dec 5, 2024
@Bownairo @nmattia
fix: Revert from 24.04 build container (#2951)
df6e86c 
Revert changes from #1946 and
#2858 until we can dynamically link to
an older libraries for broader compatibility in distributed binaries.

---------

Co-authored-by: IDX GitHub Automation <idx@dfinity.org>
Co-authored-by: Nicolas Mattia <nicolas.mattia@dfinity.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmu0 tmu0 tmu0 approved these changes

@joeodfinity joeodfinity joeodfinity approved these changes

@nmattia nmattia nmattia approved these changes

@basvandijk basvandijk basvandijk approved these changes

@NikolasHaimerl NikolasHaimerl NikolasHaimerl left review comments

@venkkatesh-sekar venkkatesh-sekar venkkatesh-sekar left review comments

@tmshlvck tmshlvck tmshlvck left review comments

@marko-k0 marko-k0 Awaiting requested review from marko-k0

Assignees
No one assigned
Labels
CI_ALL_BAZEL_TARGETS Runs all bazel targets and uploads them to S3 feat @finint @ic-owners-owners @idx @platform-operations @product-security
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@Bownairo @basvandijk @tmshlvck @nmattia @marko-k0 @joeodfinity @venkkatesh-sekar @tmu0 @NikolasHaimerl