feat(IDX): enable bzlmod #1959
Merged
feat(IDX): enable bzlmod #1959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This turns on [Bazel modules](https://bazel.build/external/module) and moves some of our (Bazel) dependency declarations to `MODULE.bazel`. This means those dependencies are specified declaratively and not imperatively as was the case in the `WORKSPACE`. This also allows us to update some dependencies, like `rules_python`, which previously created conflicts in transitive dependencies. Some dependencies were also replaced (`rules_gazelle` -> `gazelle`). This also adds a new workflow that ensures the Bazel lockfile, `MODULE.bazel.lock`, is up to date on all the platforms we support (Apple Intel, Apple Silicon, Linux x86). See workflow file for logic and details.
schneiderstefan
approved these changes
Oct 10, 2024
basvandijk
reviewed
Oct 10, 2024
cgundy
reviewed
Oct 10, 2024
cgundy
reviewed
Oct 10, 2024
cgundy
reviewed
Oct 10, 2024
cgundy
reviewed
Oct 10, 2024
nmattia
force-pushed
the
nm-bzlmod-lockfile
branch
from
27eaf6f to
32f4551
Compare
nmattia
force-pushed
the
nm-bzlmod-lockfile
branch
from
32f4551 to
78cfb1a
Compare
basvandijk
reviewed
Oct 10, 2024
marko-k0
reviewed
Oct 10, 2024
basvandijk
reviewed
Oct 10, 2024
marko-k0
reviewed
Oct 10, 2024
marko-k0
reviewed
Oct 10, 2024
cgundy
approved these changes
Oct 10, 2024
marko-k0
reviewed
Oct 10, 2024
Co-authored-by: Marko Kosmerl <marko.kosmerl@dfinity.org>
basvandijk
approved these changes
Oct 10, 2024
There was a problem hiding this comment.
Nice! Just a heads-up that #1946 also modifies WORKSPACE.bazel so whoever merges last should make sure the right ubuntu_base is being used.
marko-k0
reviewed
Oct 10, 2024
marko-k0
reviewed
Oct 10, 2024
marko-k0
reviewed
Oct 10, 2024
mraszyk
approved these changes
Oct 10, 2024
marko-k0
reviewed
Oct 10, 2024
oggy-dfin
approved these changes
Oct 10, 2024
Co-authored-by: Marko Kosmerl <marko.kosmerl@dfinity.org>
aterga
approved these changes
Oct 10, 2024
basvandijk
added a commit
that referenced
this pull request
Oct 10, 2024
This reverts commit 292b462.
This was referenced Oct 10, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 10, 2024
Test broken after #1959 Fix redfish dependency after #1959 Full context: https://dfinity.slack.com/archives/C026JQ1B2AF/p1728578113038139 --------- Co-authored-by: IDX GitHub Automation <IDX GitHub Automation>
marko-k0
pushed a commit
that referenced
this pull request
Oct 11, 2024
Test broken after #1959 Fix redfish dependency after #1959 Full context: https://dfinity.slack.com/archives/C026JQ1B2AF/p1728578113038139 --------- Co-authored-by: IDX GitHub Automation <IDX GitHub Automation>
nikolay-komarevskiy
pushed a commit
that referenced
this pull request
Oct 11, 2024
This turns on [Bazel modules](https://bazel.build/external/module) and moves some of our (Bazel) dependency declarations to `MODULE.bazel`. This means those dependencies are specified declaratively and not imperatively as was the case in the `WORKSPACE`. This also allows us to update some dependencies, like `rules_python`, which previously created conflicts in transitive dependencies. Some dependencies were also replaced (`rules_gazelle` -> `gazelle`). This also adds a new workflow that ensures the Bazel lockfile, `MODULE.bazel.lock`, is up to date on all the platforms we support (Apple Intel, Apple Silicon, Linux x86). See workflow file for logic and details. --------- Co-authored-by: Marko Kosmerl <marko.kosmerl@dfinity.org>
nikolay-komarevskiy
pushed a commit
that referenced
this pull request
Oct 11, 2024
Test broken after #1959 Fix redfish dependency after #1959 Full context: https://dfinity.slack.com/archives/C026JQ1B2AF/p1728578113038139 --------- Co-authored-by: IDX GitHub Automation <IDX GitHub Automation>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This turns on Bazel modules and moves some of our (Bazel) dependency declarations to
MODULE.bazel. This means those dependencies are specified declaratively and not imperatively as was the case in theWORKSPACE. This also allows us to update some dependencies, likerules_python, which previously created conflicts in transitive dependencies.Some dependencies were also replaced (
rules_gazelle->gazelle).This also adds a new workflow that ensures the Bazel lockfile,
MODULE.bazel.lock, is up to date on all the platforms we support (Apple Intel, Apple Silicon, Linux x86). See workflow file for logic and details.