NNS1-3450: New Exports NNS Neurons Snapshot Component #5813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
yhabib
force-pushed
the
NNS1-3450/export-neurons-button
branch
from
b0f3593 to
4ca0a4b
Compare
yhabib
force-pushed
the
NNS1-3450/export-neurons-button
branch
from
4ca0a4b to
5507458
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 21, 2024
# Motivation NNS1-3450 will require functionality to download .csv files. # Changes - New utility function to download a string in csv format as a .csv file. # Tests - Unit tests for the utility functions. - I tested it manually by adding a dummy button to the UI. I called the function with different inputs and checked that the downloaded file met expectations. # Todos - [ ] Add entry to changelog (if necessary). Not necessary Prev PR: #5815 | Next PR: #5813
This was referenced Nov 21, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 21, 2024
# Motivation The CSV table header is currently paired with the keys of the object from the array being converted into a CSV. This requires either using "translated" keys or generating a table with very technical names for the header. # Changes - Extends `generateCsvFileToSave` and `convertToCsv` to expect a label for the headers so they are decouple from the objects keys. # Tests - Added unit test # Todos - [ ] Add entry to changelog (if necessary). Not necessary Prev PR: #5834 | Next PR: #5813
frontend/src/tests/lib/components/header/ExportNeuronsButton.spec.ts
Outdated
Show resolved
Hide resolved
yhabib
changed the title
yhabib
changed the title
1 task
1 task
dskloetd
reviewed
Nov 26, 2024
frontend/src/tests/lib/components/header/ExportNeuronsButton.spec.ts
Outdated
Show resolved
Hide resolved
frontend/src/tests/lib/components/header/ExportNeuronsButton.spec.ts
Outdated
Show resolved
Hide resolved
dskloetd
reviewed
Nov 26, 2024
frontend/src/tests/lib/components/header/ExportNeuronsButton.spec.ts
Outdated
Show resolved
Hide resolved
dskloetd
approved these changes
Nov 26, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 26, 2024
…enu (#5854) # Motivation Adds neuron data export functionality to improve user access to their data, implemented behind a feature flag. # Changes - Adds the `ExportNeuronsButton` component to the `AccountMenu`. The component is behind a flag. # Tests - Unit test for the component's visibility in the main menu based on the feature flag. - Manually tested in devenv. # Todos - [ ] Add entry to changelog (if necessary). Prev PR: #5813
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Feature that allows users to export a snapshot of their Neurons state for the NNS.
We want to show Neurons that:
Requirements can be found here
Live version can be found here
Changes
csvwith a snapshot of the NNS neurons.Tests
Todos
Prev PR: #5840 | Next PR: #5854