Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NNS1-3450: Exposes Exports NNS Neurons Snapshot Component in AccountMenu #5854

Merged
merged 57 commits into from
Nov 26, 2024

Conversation

yhabib
Copy link
Contributor

@yhabib yhabib commented Nov 25, 2024

Motivation

Adds neuron data export functionality to improve user access to their data, implemented behind a feature flag.

Changes

  • Adds the ExportNeuronsButton component to the AccountMenu. The component is behind a flag.

Tests

  • Unit test for the component's visibility in the main menu based on the feature flag.
  • Manually tested in devenv.

Todos

  • Add entry to changelog (if necessary).

Prev PR: #5813

@yhabib yhabib force-pushed the NNS1-3450/export-neurons-button-to-menu branch from 1e5e8fc to b18ba0f Compare November 25, 2024 20:02
@yhabib yhabib force-pushed the NNS1-3450/export-neurons-button-to-menu branch from 1e4ec48 to 2c72fbd Compare November 26, 2024 11:03
github-merge-queue bot pushed a commit that referenced this pull request Nov 26, 2024
# Motivation

Feature that allows users to export a snapshot of their Neurons state
for the NNS.

We want to show Neurons that:  
-  are not empty  
-  have any amount, no matter how small  

Requirements can be found
[here](https://docs.google.com/document/d/1sv7KWxkhmNlFQsUoT34Vu1TmPXw2kXsmTWWxKzYtJyA/edit?tab=t.0#heading=h.vbehq4q0ohw8)
Live version can be found
[here](https://qsgjb-riaaa-aaaaa-aaaga-cai.yhabib-ingress.devenv.dfinity.network/)

# Changes

- New Component to generate and download a `csv` with a snapshot of the
NNS neurons.

# Tests

- Unit test for the new component  
- Manually tested in devenv.

# Todos

- [ ] Add entry to changelog (if necessary).

Prev PR: #5840 | Next PR: #5854
Base automatically changed from NNS1-3450/export-neurons-button to main November 26, 2024 11:24
@yhabib yhabib marked this pull request as ready for review November 26, 2024 13:13
@yhabib yhabib requested a review from a team as a code owner November 26, 2024 13:13
@yhabib yhabib requested a review from dskloetd November 26, 2024 15:55
@yhabib yhabib enabled auto-merge November 26, 2024 16:40
@yhabib yhabib added this pull request to the merge queue Nov 26, 2024
Merged via the queue into main with commit b3b1b74 Nov 26, 2024
30 checks passed
@yhabib yhabib deleted the NNS1-3450/export-neurons-button-to-menu branch November 26, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants