-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NNS1-3450: Exposes Exports NNS Neurons Snapshot Component in AccountMenu #5854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…1-3450/export-neurons-button
…1-3450/export-neurons-button
1e5e8fc
to
b18ba0f
Compare
1e4ec48
to
2c72fbd
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 26, 2024
# Motivation Feature that allows users to export a snapshot of their Neurons state for the NNS. We want to show Neurons that: - are not empty - have any amount, no matter how small Requirements can be found [here](https://docs.google.com/document/d/1sv7KWxkhmNlFQsUoT34Vu1TmPXw2kXsmTWWxKzYtJyA/edit?tab=t.0#heading=h.vbehq4q0ohw8) Live version can be found [here](https://qsgjb-riaaa-aaaaa-aaaga-cai.yhabib-ingress.devenv.dfinity.network/) # Changes - New Component to generate and download a `csv` with a snapshot of the NNS neurons. # Tests - Unit test for the new component - Manually tested in devenv. # Todos - [ ] Add entry to changelog (if necessary). Prev PR: #5840 | Next PR: #5854
…ons-button-to-menu
dskloetd
reviewed
Nov 26, 2024
dskloetd
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Adds neuron data export functionality to improve user access to their data, implemented behind a feature flag.
Changes
ExportNeuronsButton
component to theAccountMenu
. The component is behind a flag.Tests
Todos
Prev PR: #5813