Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(linting): update ESLint to latest version #6430

Merged
merged 6 commits into from
Feb 17, 2025

Conversation

yhabib
Copy link
Contributor

@yhabib yhabib commented Feb 15, 2025

Motivation

We want to update ESLint to its latest version, as it is no longer supported. This follows up on #6391, and it is important because ESLint@8 is outdated.

Screenshot 2025-02-15 at 11 30 43

To minimize the necessary changes due to the differences in how some rules apply now compared to before, I've overwritten certain rules. This will be addressed in a follow-up.

Changes

  • Upgrades ESLint and relevant packages to the latest version.
  • Installs new required packages.
  • Removes packages that are no longer needed.

Tests

  • Linting should pass as it did previously.

Todos

  • Add entry to changelog (if necessary).
    Not necessary

@yhabib
Copy link
Contributor Author

yhabib commented Feb 15, 2025

Failing because of

ENV NODE_VERSION=16.17.1

We have a missmatch with dfx
"NODE_VERSION": "18.14.2",

Blocked by #6431

@yhabib yhabib force-pushed the yhabib/housekeeping/eslint/latest branch from d9dbf76 to bae1e82 Compare February 15, 2025 11:36
@yhabib yhabib force-pushed the yhabib/housekeeping/eslint/latest branch 3 times, most recently from c33135c to 364ec4c Compare February 15, 2025 11:58
@yhabib yhabib changed the base branch from main to yhabib/housekeeping/node-version February 15, 2025 11:58
Base automatically changed from yhabib/housekeeping/node-version to main February 17, 2025 10:08
@yhabib yhabib force-pushed the yhabib/housekeeping/eslint/latest branch from 837c7fa to ffbed48 Compare February 17, 2025 10:10
@yhabib yhabib marked this pull request as ready for review February 17, 2025 11:09
@yhabib yhabib requested a review from a team as a code owner February 17, 2025 11:09
@yhabib yhabib force-pushed the yhabib/housekeeping/eslint/latest branch from ffbed48 to 3ae2be5 Compare February 17, 2025 11:09
@yhabib yhabib added this pull request to the merge queue Feb 17, 2025
Merged via the queue into main with commit 6871f6c Feb 17, 2025
32 checks passed
@yhabib yhabib deleted the yhabib/housekeeping/eslint/latest branch February 17, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants