Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(node): update Node.js version in Dockerfile and config.json #6431

Merged
merged 2 commits into from
Feb 17, 2025

Conversation

yhabib
Copy link
Contributor

@yhabib yhabib commented Feb 15, 2025

Motivation

We have a version mismatch of Node between our dockerfile and config.json. Node 16 has not been supported for some time. This PR updates both the Dockerfile and config to the same version we use for development.

Additionally, we could upgrade to the latest patch, which addresses some security vulnerabilities (v18.20.6) but this is not done in this PR.

Note: Version 18.20 addressed a "breaking change" introduced in v18 regarding how Date manages the space between the time and AM/PM. This adjustment was made following the update to the standard.

In many formatting patterns, ASCII spaces are replaced with Unicode spaces (e.g., a "thin space").

Screenshot 2025-02-15 at 11 54 06

Changes

  • Bump version of node in dockerfile and config.json to 18.20.5

Tests

  • It should build
  • Tested in devenv

Todos

  • Add entry to changelog (if necessary).
    Not necessary

@yhabib yhabib changed the title update node to 18.20 chore(node): update Node.js version in Dockerfile and dfx Feb 15, 2025
@yhabib yhabib marked this pull request as ready for review February 17, 2025 06:37
@yhabib yhabib requested a review from a team as a code owner February 17, 2025 06:37
@yhabib yhabib changed the title chore(node): update Node.js version in Dockerfile and dfx chore(node): update Node.js version in Dockerfile and config.json Feb 17, 2025
Dockerfile Show resolved Hide resolved
@yhabib yhabib requested a review from dskloetd February 17, 2025 09:06
Dockerfile Show resolved Hide resolved
@yhabib yhabib added this pull request to the merge queue Feb 17, 2025
Merged via the queue into main with commit 46474ad Feb 17, 2025
32 checks passed
@yhabib yhabib deleted the yhabib/housekeeping/node-version branch February 17, 2025 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants