Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce uniqueness naming for query blocks #2675

Closed
MichelDiz opened this issue Oct 18, 2018 · 1 comment
Closed

Enforce uniqueness naming for query blocks #2675

MichelDiz opened this issue Oct 18, 2018 · 1 comment
Assignees
@gitlw
Labels
kind/maintenance Maintenance tasks, such as refactoring, with no impact in features.

Comments

@MichelDiz
Copy link
Contributor

Today the Dgraph allows naming multiple distinct blocks with the same name. And so it merges the results of all the blocks as one. Such use is not predicted and is a wrong usage.
@manishrjain manishrjain added the kind/maintenance Maintenance tasks, such as refactoring, with no impact in features. label Oct 19, 2018
@gitlw gitlw assigned gitlw and unassigned srfrog Oct 30, 2018
@gitlw
Copy link

gitlw commented Oct 30, 2018

@srfrog FYI, I can take over this task.

This was referenced Oct 30, 2018
Closed
Merged
gitlw pushed a commit that referenced this issue Nov 1, 2018
Forbidding duplicate query aliases
2970023 
Forbidding duplicate query aliases. Fixes #2675
@MichelDiz MichelDiz mentioned this issue Dec 9, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gitlw gitlw

Labels
kind/maintenance Maintenance tasks, such as refactoring, with no impact in features.
Milestone
No milestone
Development

No branches or pull requests
4 participants
@gitlw @manishrjain @MichelDiz @srfrog