Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Returning error for duplicate query aliases #2708

Closed
wants to merge 1 commit into from
Closed

Returning error for duplicate query aliases #2708

wants to merge 1 commit into from

Conversation

gitlw
Copy link

@gitlw gitlw commented Oct 30, 2018 •
edited by manishrjain
Loading

Fixes #2675
Added unit test for the code improvement.

This change is Reviewable

manishrjain
manishrjain suggested changes Oct 30, 2018
View reviewed changes
Copy link
Contributor

@manishrjain manishrjain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @gitlw)

gql/parser.go, line 471 at r1 (raw file):

	it := lexer.NewIterator()
	fmap := make(fragmentMap)
	seenQueryAliases := make(map[string]bool)

Instead of doing this here, can you do a validate(result), after parsing?

@gitlw gitlw closed this Oct 31, 2018
@gitlw gitlw deleted the forbid_duplicate_query_blocks branch November 8, 2018 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manishrjain manishrjain manishrjain requested changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gitlw @manishrjain