-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add auto resizing for plugins [LIBS-487] #1355
Conversation
}: { | ||
pluginSource?: string | ||
pluginShortName?: string | ||
propsToPass: any | ||
}): JSX.Element => { | ||
const iframeRef = useRef<HTMLIFrameElement>(null) | ||
|
||
// we do not know what is being sent in passed props, so for stable reference, memoize using JSON representation | ||
const propsToPassNonMemoizedJSON = JSON.stringify(propsToPassNonMemoized) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stable reference for props is handled in a more thought-out-manner in #1351
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am thinking though, maybe it makes more sense to have a min-height
property? and kind of related, do we need the div to have overflow-y: scroll
or auto
or will that work out of the box
As in, have
this worked out of the box for me, but I only tested in chrome and firefox, so could look into that more. |
yeah this is different requirement probably .. so can leave it for now until there is a need. |
🎉 This PR is included in version 3.10.0-alpha.4 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 3.11.0-alpha.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Implements LIBS-487
Note this change requires updates in both app-runtime and in app-platform (see also app-platform PR: dhis2/app-platform#814)
Key features
Description
See ticket
Checklist
Known issues
As noted on the ticket, I'm not totally sure what the behaviour should be for autoresizing of width.
Screenshots
Top/Orange box has a plugin with autoresizing (of both width/height); Bottom/Blue box has fixed width