UI to share sheets #25
Comments
|
It looks like we can launch the Sharing Dialog, but even if the user has permission to the file, our API will still get a 404 because we're using the |
Refs #25 In particular, we no longer show "Loading" if there was an error, because we probably aren't. Instead, we delete the :sheet-sources entry if it had an :err on a successful load, and when initiating a load. This commit also establishes the convention that if the sheet error is an (ex-info), the associated data map is a set of flags indicating things that might have gone wrong. Currently we support :permissions? which means that the active user may not have permission to view the file; the resolution of this is provider-specific---for gdrive, we may try letting the user open the file with Picker as a way of granting the app permission....
|
The easiest solution is to probably just request the full If we don't have permission to view a file, we can direct the user to request access with a link like: |
|
Okay! Got OAuth developer verification just now so we can use |
* Refactor provider-specific error handling/resolution First step toward #25 * Cleanup unused code * Support filtering out shared sheets vs my sheets It'd be nice to persist the preference to local storage... * Revoke scopes on signout! from gdrive * Fix querying in a space for which we no longer request the scope * Prompt to request readonly scope if we can't load a sheet Next: if we have read scope but still can't read it, it's probably not been shared with us and we need to request that it be shared * Add "request access to file" UX flow * Add API wrapper for showing the Share dialog * Add a share button for "my" sheets * Populate :mine? externally so it doesn't get overwritten See the NOTEs in the comments
|
Closed by #54 |
So other people can view it
The text was updated successfully, but these errors were encountered: