Support sharing and requesting access to sheets #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First step toward #25
It'd be nice to persist the preference to local storage...
Next: if we have read scope but still can't read it, it's probably not been shared with us and we need to request that it be shared
See the NOTEs in the comments
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now we only support read-only mode, but it's a start. Attempting write to a shared file just now results in a 403 error that looks like:
In this case, my user was granted access to the file as an editor, so my user can theoretically edit the file—it's just that I only have the
drive.readonlyaccess to it. This works out nicely, though; we should be able to use that as a cue to prompt the user to grant full drive permissions in order to act as a GM.I'll open a separate ticket for write-access sharing (#53), since we may want to try to do live updates as part of that, and another ticket for Drive UI integration (#55), which will make sharing a bit smoother (hopefully it will let users open files directly from the "sharable link").